chore(wallet): bip39.mnemonic is async#1051
Merged
DalderupMaurice merged 2 commits intodevelopfrom Jul 31, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1051 +/- ##
========================================
Coverage 51.48% 51.48%
========================================
Files 237 237
Lines 2016 2016
Branches 267 267
========================================
Hits 1038 1038
Misses 813 813
Partials 165 165 |
| } | ||
|
|
||
| const seed = bip39.mnemonicToSeed(mnemonic, passphrase); | ||
| const seed = await bip39.mnemonicToSeed(mnemonic, passphrase); |
Member
There was a problem hiding this comment.
aaaaaaaaaaaah this changed to an async function since the 3.0.x release.
There's also a sync version if I am not mistaken, but this is fine aswell :)
Contributor
Author
There was a problem hiding this comment.
Better safe than sorry? 😎
DalderupMaurice
approved these changes
Jul 31, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Wallet should be async, since bip39.mnemonic returns a promise.
Motivation and Context
Leaving this unfixed breaks the sign in process
How Has This Been Tested?
/
Screenshots (if appropriate)
/
Types of changes
Checklist
Documentation
Closing issues
Fixes #