Add option for ignoring values#141
Merged
norwoodj merged 2 commits intonorwoodj:masterfrom Jun 29, 2022
Merged
Conversation
Ignoring is set up using `# -- @ignored` tag
mjpitz
reviewed
May 10, 2022
Replace `# -- @ignore` with simple `@ignore`
mjpitz
reviewed
May 19, 2022
| if !strings.Contains(node.HeadComment, "@ignore") { | ||
| removeIgnored(node, node.Kind) | ||
| newContent = append(newContent, node) | ||
| } else if parentKind == yaml.MappingNode { |
There was a problem hiding this comment.
Based on your comment below, it seems this should be a separate if block and not part of the prior if?
Contributor
Author
There was a problem hiding this comment.
This can be reworded to:
if HeadComment contains @ignore don't include it in newContent. If root node is MappingNode don't include the next node as well
norwoodj
approved these changes
Jun 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignoring is set up using
# -- @ignoredtagDisclosure: this is my first code written in go - suggestions are more than welcome :)