Skip to content

fixes compilation when LIBHEIF is enabled#1290

Closed
souravdas142 wants to merge 1 commit intonomacs:masterfrom
souravdas142:LIBHEIF_enable_fix
Closed

fixes compilation when LIBHEIF is enabled#1290
souravdas142 wants to merge 1 commit intonomacs:masterfrom
souravdas142:LIBHEIF_enable_fix

Conversation

@souravdas142
Copy link
Copy Markdown

When enables
-DENABLE_HEIF=ON

still its showing
nomacs will be compiled with HEIF support .................... NO

@scrubbbbs
Copy link
Copy Markdown
Collaborator

It seems ENABLE_LIBHEIF is not mentioned anywhere in the source code or build files, so the proper fix would be to remove it. It may have been retained to avoid breaking package maintainers' scripts.

HEIF support is now provided by a qt imageformat plugin such as kimageformats.

@leejuyuu
Copy link
Copy Markdown
Collaborator

leejuyuu commented Mar 22, 2025

I remember @novomesk mentioned that`` ENABLE_HEIF is used only for MSVC builds.

@scrubbbbs
Copy link
Copy Markdown
Collaborator

My mistake, I searched for the wrong string. Yes, it is in the msvc cmake files. So it can be omitted from unix build target so it won't show when it doesn't have any effect.

@novomesk
Copy link
Copy Markdown
Collaborator

IF(libheif_FOUND) will be removed. It is most probably some old remnant from the times, when nomacs built qt-heif-image-plugin

On Linux we recommend to use heif plugin from kimageformats package.

@novomesk novomesk closed this Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants