-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
Overiding custom acessibility names on navigation button #8087
Description
Check that this is really a bug
- I confirm
Reproduction link
https://xvfh43.csb.app/
Bug description
So we've been using the next and prev buttons with buttons instead of divs - for better semantics. Also with our own button accNames titles as hidden spans inside them.
We prefer this method because then it can be translatable. The aria-label attribute isn't. This method worked fine all through v11 but just updated to v12 and noticed that the buttons have an svg being injected in.
I see it's a feature from the blog but also noticed it was stripping out all our hidden spans from the dom too and our custom accNames on the buttons aren't being used which.
Expected Behavior
A way to also keep our hidden spans inside the prev and next buttons?
Actual Behavior
the hidden spans are being removed entirely when the svgs are being injected in
Swiper version
12
Platform/Target and Browser Versions
macOS firefox
Validations
- Follow our Code of Conduct
- Read the docs.
- Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
- Make sure this is a Swiper issue and not a framework-specific issue
Would you like to open a PR for this bug?
- I'm willing to open a PR