Repository navigation
fix(mail-composer): keep httpHeaders and tls for href alternatives and icalEvent - #1862
Merged
andris9 merged 1 commit intoSep 11, 2026
Merged
Conversation
…d icalEvent
Alternatives and the icalEvent normalized an href content descriptor into
{ href } only, dropping the httpHeaders and tls options that attachments
already forward. Remote text/html alternatives and calendar events fetched
without the caller's auth headers or TLS settings. Forward both options the
same way getAttachments does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NB! Nodemailer is frozen, so no new features please, only bug fixes.
Attachments forwarded httpHeaders and tls to the URL fetch, but alternatives and the icalEvent dropped them when normalizing an href into a content descriptor. A text/html alternative or calendar event fetched from a URL went out without the caller's auth headers or TLS settings. This forwards both options the same way getAttachments already does.
Tests: two new unit cases plus the existing live URL-fetch test now asserts the header arrives for the html alternative. Full suite 1277/1277 green, lint clean.