Skip to content

fix(mail-composer): keep httpHeaders and tls for href alternatives and icalEvent - #1862

Merged
andris9 merged 1 commit into
nodemailer:masterfrom
soroush5:fix/alternative-href-fetch-options
Sep 11, 2026
Merged

andris9 merged 1 commit into
nodemailer:masterfrom
soroush5:fix/alternative-href-fetch-options

Conversation

@soroush5

Copy link
Copy Markdown
Contributor

NB! Nodemailer is frozen, so no new features please, only bug fixes.

Attachments forwarded httpHeaders and tls to the URL fetch, but alternatives and the icalEvent dropped them when normalizing an href into a content descriptor. A text/html alternative or calendar event fetched from a URL went out without the caller's auth headers or TLS settings. This forwards both options the same way getAttachments already does.

Tests: two new unit cases plus the existing live URL-fetch test now asserts the header arrives for the html alternative. Full suite 1277/1277 green, lint clean.

…d icalEvent

Alternatives and the icalEvent normalized an href content descriptor into
{ href } only, dropping the httpHeaders and tls options that attachments
already forward. Remote text/html alternatives and calendar events fetched
without the caller's auth headers or TLS settings. Forward both options the
same way getAttachments does.
@andris9
andris9 merged commit 7f502be into nodemailer:master Sep 11, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants