Repository navigation
fix: resolve well-known services by their primary domains - #1859
Merged
andris9 merged 1 commit intoSep 10, 2026
Merged
Conversation
wellKnown('[email protected]') and wellKnown('[email protected]')
returned false because icloud.com and fastmail.com were missing
from the domains lists, so service-based SMTP setup silently got
no host/port for those addresses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NB! Nodemailer is frozen, so no new features please, only bug fixes.
Fixes #1858.
wellKnown('[email protected]') and wellKnown('[email protected]') returned false because icloud.com and fastmail.com were missing from the domains lists, so service-based setup silently got no SMTP settings for those addresses. Adds the two domains; no behavior change otherwise.
Tests: added lookup cases to test/well-known/well-known-test.ts (6/6 pass), neighboring smtp-transport suite 14/14 pass, npm run lint and format:check clean.