Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodemailer/nodemailer
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v8.0.8
Choose a base ref
...
head repository: nodemailer/nodemailer
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v8.0.9
Choose a head ref
  • 2 commits
  • 8 files changed
  • 3 contributors

Commits on May 26, 2026

  1. fix: two pending security advisories (jsonTransport access bypass, Li…

    …st-* CRLF injection) (#1820)
    
    * fix: enforce disableFileAccess/disableUrlAccess in content resolution
    
    shared.resolveContent() read local files and fetched HTTP(S) URLs without
    consulting disableFileAccess/disableUrlAccess. The MIME streaming path in
    mime-node enforces those flags, but jsonTransport (mail.normalize ->
    resolveAll) and the attachDataUrls pre-plugin (_convertDataImages) resolve
    content through shared.resolveContent() before streaming, bypassing the
    policy. An attacker controlling a message field such as an attachment
    `path` or `text.href` could read local files into the JSON output or force
    outbound HTTP requests despite the flags being set.
    
    resolveContent() now accepts an optional access-policy object (the legacy
    (data, key, callback) signature still works) and rejects blocked file/URL
    content with EFILEACCESS/EURLACCESS, matching mime-node. resolveAll() and
    _convertDataImages() pass the message's flags through. Behavior is
    unchanged when the flags are unset.
    
    Refs: GHSA-wqvq-jvpq-h66f
    
    Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
    
    * fix: strip CRLF from List-* header comments
    
    _getListHeaders() inserted list.*.comment values into prepared List-*
    headers without neutralizing CR/LF. mimeFuncs.isPlainText() does not treat
    CR or LF as disallowed, so a comment passed the plain-text check and was
    emitted verbatim through foldLines(), bypassing the CRLF normalization that
    ordinary (unprepared) header values get in _encodeHeaderValue(). An
    attacker influencing any list.*.comment field (help, unsubscribe,
    subscribe, post, owner, archive, id) could inject arbitrary additional
    message headers.
    
    CR/LF in the comment are now collapsed to a space before the prepared
    header is built, matching the normalization used for ordinary header
    values. The url field was already sanitized by _formatListUrl().
    
    Refs: GHSA-268h-hp4c-crq3
    
    Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
    
    ---------
    
    Co-authored-by: Claude Opus 4.7 (1M context) <[email protected]>
    andris9 and claude authored May 26, 2026
    Configuration menu
    Copy the full SHA
    5f69497 View commit details
    Browse the repository at this point in the history
  2. chore(master): release 8.0.9 (#1821)

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    github-actions[bot] authored May 26, 2026
    Configuration menu
    Copy the full SHA
    07303cb View commit details
    Browse the repository at this point in the history
Loading