Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodemailer/nodemailer
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v8.0.10
Choose a base ref
...
head repository: nodemailer/nodemailer
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v8.0.11
Choose a head ref
  • 15 commits
  • 28 files changed
  • 3 contributors

Commits on May 30, 2026

  1. docs: do not manage CVEs, only GitHub Security Advisories (#1825)

    Reporters who want a CVE should request one themselves.
    
    Co-authored-by: Claude Opus 4.8 (1M context) <[email protected]>
    andris9 and claude authored May 30, 2026
    Configuration menu
    Copy the full SHA
    a6bcbf6 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2026

  1. fix: resolve oauth2_provision_cb at send time for non-pooled SMTP tra…

    …nsports
    
    The transport-level auth object is built in the SMTPTransport constructor,
    before Mail assigns transporter.mailer, so a provision callback registered
    with transporter.set('oauth2_provision_cb', ...) was never picked up when
    sendMail() was called without a per-message auth value and the send failed
    with EAUTH. Re-check the mailer for the callback when the cached auth is
    returned from getAuth(). Pooled transports, verify(), and per-message auth
    were unaffected.
    
    Reported in nodemailer-upstream-bugs-2026-06-10 (issue 1), dates back to
    v3.0.0.
    
    Co-Authored-By: Claude Fable 5 <[email protected]>
    andris9 and claude committed Jun 10, 2026
    Configuration menu
    Copy the full SHA
    203c8ec View commit details
    Browse the repository at this point in the history
  2. fix: include icalEvent path/href content in the application/ics attac…

    …hment
    
    getAttachments() appended the icalEvent copy without mapping path/href/data
    uri values into a content entry the way regular attachments are mapped, so
    _createContentNode fell back to an empty body and the application/ics
    attachment part was sent with zero-length content (the text/calendar
    alternative part was populated correctly).
    
    The normalization now lives in a shared _getIcalEvent() helper used by both
    getAlternatives() and getAttachments(); the two copies of the event share a
    single content object marked with the existing _resolve mechanism, so a file
    is read (or an URL fetched) only once per message.
    
    Reported in nodemailer-upstream-bugs-2026-06-10 (issue 2).
    
    Co-Authored-By: Claude Fable 5 <[email protected]>
    andris9 and claude committed Jun 10, 2026
    Configuration menu
    Copy the full SHA
    b801c48 View commit details
    Browse the repository at this point in the history
  3. fix: strip the url scheme from List-ID header values

    The scheme-stripping regex used an invalid quantifier (comma-2 in braces),
    which JavaScript treats as a literal string, so the http:// prefix that
    _formatListUrl adds to bare domains was never removed and the emitted
    List-ID violated the RFC 2919 <domain> form.
    
    Reported in nodemailer-upstream-bugs-2026-06-10 (issue 3).
    
    Co-Authored-By: Claude Fable 5 <[email protected]>
    andris9 and claude committed Jun 10, 2026
    Configuration menu
    Copy the full SHA
    77e5885 View commit details
    Browse the repository at this point in the history
  4. fix: apply the transport-level newline option in stream and sendmail …

    …transports
    
    When newline handling moved into MimeNode in v6.6.0 the transport-level
    piping was removed, leaving the documented transport option a no-op:
    stream-transport only mentioned it in a log line and sendmail-transport
    ignored it entirely (the message-level option kept working). Restore the
    LeWindows/LeUnix transform in both transports, applied only when the option
    is set so default output is unchanged.
    
    Reported in nodemailer-upstream-bugs-2026-06-10 (issue 4).
    
    Co-Authored-By: Claude Fable 5 <[email protected]>
    andris9 and claude committed Jun 10, 2026
    Configuration menu
    Copy the full SHA
    cb4f904 View commit details
    Browse the repository at this point in the history
  5. fix: return the promise from every resolveContent branch

    When called without a callback, only the plain string/Buffer path reached
    the final return statement; the stream, URL, file path, data uri, and empty
    content branches returned early, so awaiting resolveContent resolved to
    undefined immediately for those content types. The branching body now lives
    in an inner function and the promisified wrapper has a single exit.
    
    Also replaces an unreachable-intent Buffer.from(0) call, which throws a
    TypeError, with Buffer.alloc(0) for data uris that contain no comma.
    
    Reported in nodemailer-upstream-bugs-2026-06-10 (issue 5).
    
    Co-Authored-By: Claude Fable 5 <[email protected]>
    andris9 and claude committed Jun 10, 2026
    Configuration menu
    Copy the full SHA
    07ffe8c View commit details
    Browse the repository at this point in the history
  6. fix: tag AWS SES transport errors with the ESES code

    The ESES code has been defined in lib/errors.js but was never assigned to
    any error. Tag AWS SDK rejections surfaced by SESTransport send() and
    verify() with code=ESES when the error carries no code of its own (SDK v3
    errors only have a name), keeping the original error object and its AWS
    properties intact.
    
    Reported in nodemailer-upstream-bugs-2026-06-10 (issue 7).
    
    Co-Authored-By: Claude Fable 5 <[email protected]>
    andris9 and claude committed Jun 10, 2026
    Configuration menu
    Copy the full SHA
    efa647a View commit details
    Browse the repository at this point in the history
  7. docs: correct stale timeout defaults in SMTPConnection options JSDoc

    The comments claimed a 10 second greeting timeout and a 1 hour socket
    timeout; the actual constants are 30 seconds (greeting), 2 minutes
    (connection) and 10 minutes (socket).
    
    Reported in nodemailer-upstream-bugs-2026-06-10 (minor observations).
    
    Co-Authored-By: Claude Fable 5 <[email protected]>
    andris9 and claude committed Jun 10, 2026
    Configuration menu
    Copy the full SHA
    8620f2f View commit details
    Browse the repository at this point in the history
  8. chore: format CLAUDE.md with prettier

    Co-Authored-By: Claude Fable 5 <[email protected]>
    andris9 and claude committed Jun 10, 2026
    Configuration menu
    Copy the full SHA
    e0a4928 View commit details
    Browse the repository at this point in the history
  9. chore: update dev dependencies

    @aws-sdk/client-sesv2 3.1037.0 -> 3.1065.0, eslint 10.2.1 -> 10.4.1,
    globals 17.5.0 -> 17.6.0, prettier 3.8.3 -> 3.8.4,
    smtp-server 3.18.4 -> 3.18.5. Full test suite, lint, format check and the
    Node 6 syntax-compat check all pass with the updated versions.
    
    Co-Authored-By: Claude Fable 5 <[email protected]>
    andris9 and claude committed Jun 10, 2026
    Configuration menu
    Copy the full SHA
    cb9da47 View commit details
    Browse the repository at this point in the history
  10. chore: add CodeQL code scanning workflow

    Mirrors the emailengine setup: weekly scheduled scan plus push/PR scans on
    master, analyzing workflow files and JavaScript with build-mode none. The
    config excludes test/ (intentionally insecure fixtures: disabled TLS
    verification, plaintext-auth mock servers) and examples/ from analysis.
    
    Co-Authored-By: Claude Fable 5 <[email protected]>
    andris9 and claude committed Jun 10, 2026
    Configuration menu
    Copy the full SHA
    0cee4fe View commit details
    Browse the repository at this point in the history
  11. fix: parse Ethereal response props without polynomial regex backtracking

    getTestMessageUrl() extracted the trailing bracket group of the server
    response with a regex that CodeQL flagged for polynomial backtracking on
    adversarial responses (js/polynomial-redos). Replace it with linear string
    scanning; a 200k-case fuzz comparison confirmed the old and new parsers
    extract identical values.
    
    Co-Authored-By: Claude Fable 5 <[email protected]>
    andris9 and claude committed Jun 10, 2026
    Configuration menu
    Copy the full SHA
    067aebe View commit details
    Browse the repository at this point in the history
  12. chore: harden workflow token permissions and update GitHub Actions

    Set explicit GITHUB_TOKEN permissions in the test workflow (contents: read)
    and the stale workflow (issues + pull-requests: write), resolving the
    CodeQL actions/missing-workflow-permissions alerts. Update actions/checkout
    and actions/setup-node to v5 and actions/stale to v10, which run on
    Node.js 24 and clear the runner deprecation annotations.
    
    Co-Authored-By: Claude Fable 5 <[email protected]>
    andris9 and claude committed Jun 10, 2026
    Configuration menu
    Copy the full SHA
    cf5195c View commit details
    Browse the repository at this point in the history
  13. refactor: remove dead checks flagged by Code Quality analysis

    Resolves the CodeQL code-quality findings shown in the Security and
    quality dashboard, with no behavior changes:
    
    - ses-transport: verify() assigned a fallback region that nothing read and
      passed a superfluous second argument to its single-parameter callback
      (js/useless-assignment-to-local, js/superfluous-trailing-arguments)
    - mime-types detectExtension(), smtp-connection _onData() and
      smtp-transport getAuth() rechecked values already guaranteed truthy by
      their guard clauses (js/trivial-conditional)
    
    Co-Authored-By: Claude Fable 5 <[email protected]>
    andris9 and claude committed Jun 10, 2026
    Configuration menu
    Copy the full SHA
    4358caf View commit details
    Browse the repository at this point in the history
  14. chore(master): release 8.0.11 (#1826)

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    github-actions[bot] authored Jun 10, 2026
    Configuration menu
    Copy the full SHA
    e3b1bda View commit details
    Browse the repository at this point in the history
Loading