Skip to content

Commit efa647a

Browse files
andris9claude
andcommitted
fix: tag AWS SES transport errors with the ESES code
The ESES code has been defined in lib/errors.js but was never assigned to any error. Tag AWS SDK rejections surfaced by SESTransport send() and verify() with code=ESES when the error carries no code of its own (SDK v3 errors only have a name), keeping the original error object and its AWS properties intact. Reported in nodemailer-upstream-bugs-2026-06-10 (issue 7). Co-Authored-By: Claude Fable 5 <[email protected]>
1 parent 07ffe8c commit efa647a

2 files changed

Lines changed: 104 additions & 1 deletion

File tree

‎lib/ses-transport/index.js‎

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,22 @@
33
const EventEmitter = require('events');
44
const packageData = require('../../package.json');
55
const shared = require('../shared');
6+
const errors = require('../errors');
67
const LeWindows = require('../mime-node/le-windows');
78
const MimeNode = require('../mime-node');
89

10+
/**
11+
* Tags AWS SDK rejections that carry no `code` property (SDK v3 errors only
12+
* have a `name`) with the generic SES transport error code, keeping the
13+
* original error object intact
14+
*/
15+
function tagSesError(err) {
16+
if (err && typeof err === 'object' && !err.code) {
17+
err.code = errors.ESES;
18+
}
19+
return err;
20+
}
21+
922
/**
1023
* Generates a Transport object for AWS SES
1124
*
@@ -157,6 +170,7 @@ class SESTransport extends EventEmitter {
157170
});
158171
})
159172
.catch(err => {
173+
tagSesError(err);
160174
this.logger.error(
161175
{
162176
err,
@@ -188,7 +202,7 @@ class SESTransport extends EventEmitter {
188202

189203
const cb = err => {
190204
if (err && !['InvalidParameterValue', 'MessageRejected'].includes(err.code || err.Code || err.name)) {
191-
return callback(err);
205+
return callback(tagSesError(err));
192206
}
193207
return callback(null, true);
194208
};

‎test/ses-transport/ses-transport-test.js‎

Lines changed: 89 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,95 @@ describe('SES Transport Tests', { timeout: 90 * 1000 }, () => {
127127
});
128128
});
129129

130+
it('should tag send errors with the ESES code', (t, done) => {
131+
let transport = nodemailer.createTransport({
132+
SES: {
133+
sesClient: {
134+
config: {
135+
region() {
136+
return Promise.resolve('eu-west-1');
137+
}
138+
},
139+
send() {
140+
return new Promise((resolve, reject) => {
141+
// AWS SDK v3 style error: a `name` but no `code` property
142+
let error = new Error('Access denied');
143+
error.name = 'AccessDeniedException';
144+
setImmediate(() => reject(error));
145+
});
146+
}
147+
},
148+
SendEmailCommand
149+
}
150+
});
151+
152+
transport.sendMail({ from: '[email protected]', to: '[email protected]', subject: 'test', text: 'test' }, err => {
153+
assert.ok(err);
154+
assert.strictEqual(err.code, 'ESES');
155+
assert.strictEqual(err.name, 'AccessDeniedException');
156+
done();
157+
});
158+
});
159+
160+
it('should not overwrite an existing error code on send errors', (t, done) => {
161+
let transport = nodemailer.createTransport({
162+
SES: {
163+
sesClient: {
164+
config: {
165+
region() {
166+
return Promise.resolve('eu-west-1');
167+
}
168+
},
169+
send() {
170+
return new Promise((resolve, reject) => {
171+
let error = new Error('Throttled');
172+
error.code = 'Throttling';
173+
setImmediate(() => reject(error));
174+
});
175+
}
176+
},
177+
SendEmailCommand
178+
}
179+
});
180+
181+
transport.sendMail({ from: '[email protected]', to: '[email protected]', subject: 'test', text: 'test' }, err => {
182+
assert.ok(err);
183+
assert.strictEqual(err.code, 'Throttling');
184+
done();
185+
});
186+
});
187+
188+
it('should reject verify with the ESES code for unexpected errors', (t, done) => {
189+
let transport = nodemailer.createTransport({
190+
SES: {
191+
sesClient: {
192+
config: {
193+
region() {
194+
return Promise.resolve('eu-west-1');
195+
}
196+
},
197+
send() {
198+
return new Promise((resolve, reject) => {
199+
let error = new Error('Access denied');
200+
error.name = 'AccessDeniedException';
201+
setImmediate(() => reject(error));
202+
});
203+
}
204+
},
205+
SendEmailCommand
206+
}
207+
});
208+
209+
transport.verify().then(
210+
() => done(new Error('verify should have failed')),
211+
err => {
212+
assert.strictEqual(err.code, 'ESES');
213+
assert.strictEqual(err.name, 'AccessDeniedException');
214+
done();
215+
}
216+
);
217+
});
218+
130219
it('should sign message with DKIM, using AWS SES JavaScript SDK v2', (t, done) => {
131220
let transport = nodemailer.createTransport({
132221
SES: {

0 commit comments

Comments
 (0)