change RELEASE_URLBASE to the Unofficial Builds server #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Member
|
lgtm, let's give it a go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a recipe that downloads a copy of the headers to be included in the Unofficial Builds releases and changes the RELEASE_URLBASE to point to that copy.
The node-gyp changes in nodejs/node-gyp#1875 require this. Windows ARM64 releases need to download
node.libfrom this server. Changing node-gyp to getnode.libfrom here and the headers from the main server doesn't make much sense to me. This approach makes it more consistent, at the expense of having to duplicate the headers files.@rvagg can you take a look? I haven't tested this. I plan to land this, let docker update and then fix anything that needs fixing. But I can test the changes in the server and update this PR if you prefer. In any case, I'll run the new recipe for v12.8.0 which I'm using to test the node-gyp side.