set CCACHE_BASEDIR to properly enable ccache on all builds#215
Merged
Conversation
sxa
marked this pull request as draft
February 20, 2026 13:43
sxa
marked this pull request as ready for review
February 20, 2026 22:35
Signed-off-by: Stewart X Addison <[email protected]>
sxa
force-pushed
the
ccache_dir_everywhere
branch
from
February 21, 2026 12:20
09d97f5 to
9a7e3e1
Compare
Member
Author
|
Force push to fix commit message |
12 tasks
rvagg
approved these changes
Feb 23, 2026
rvagg
left a comment
Member
There was a problem hiding this comment.
sgtm, do you have any ccache stats (or whatever that command is) to show them being used?
Member
Author
I didn't make a note after the first run but the build times for the second run in a different directory (building 25.6.0 then 25.6.1 from a clean cache) were significantly different after implementing this (about 2-3 times quicker) Here's the final cache information after building those two (locally on my laptop with the alpine recipes) - although this was after rebuilding 25.6.1 one extra time which would have been completely cached. |
Member
|
looks healthy 👍 |
richardlau
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #214 (which prototyped the change on riscv64 only) now that I've verified that it works ok on the Alpine builds (out most important ones as they are used by the docker-node project, so I expect this to work on all the others (and if it doesn't, we can fix it up later!)
Fixes #213