fix: request body edge cases#67
Merged
ronag merged 1 commit intonodejs:masterfrom May 6, 2020
Merged
Conversation
ronag
commented
May 5, 2020
ronag
force-pushed
the
fix-request-body-edge-case
branch
2 times, most recently
from
9c9d507 to
68e5e9e
Compare
This comment has been minimized.
This comment has been minimized.
ronag
force-pushed
the
fix-request-body-edge-case
branch
12 times, most recently
from
e5eddc1 to
0a80029
Compare
Readable can emit 'end' after .destroy() as well as legacy streams might not implement the whole Readable contract properly. Try to handle these edge cases better. Fixes: nodejs#66
ronag
force-pushed
the
fix-request-body-edge-case
branch
from
0a80029 to
6d932fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Readable can emit 'end' after .destroy() as well
as legacy streams might not implement the whole
Readable contract properly. Try to handle these
edge cases better.
Fixes: #66