Repository navigation
test(wpt): fix startup checks and failure logging - #6152
Merged
Merged
Conversation
WPT now logs HTTP listeners that support CONNECT as HTTPS servers. Accept both startup messages so the readiness checks work with the pinned WPT snapshot and current upstream WPT. Signed-off-by: Filip Skokan <[email protected]> Assisted-by: Codex
WPT timeouts and thrown strings can produce subtest results with a null stack. Treat missing stacks as empty strings when formatting failure details so logging does not abort the run before writing the report. Signed-off-by: Filip Skokan <[email protected]> Assisted-by: Codex
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6152 +/- ##
=======================================
Coverage 91.66% 91.66%
=======================================
Files 113 113
Lines 44041 44041
=======================================
Hits 40372 40372
Misses 3669 3669 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
metcoder95
approved these changes
Nov 4, 2026
nodejs-github-bot
pushed a commit
to nodejs/node
that referenced
this pull request
Nov 5, 2026
Signed-off-by: Filip Skokan <[email protected]> PR-URL: #67229 Refs: nodejs/undici#6152 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95
pushed a commit
to nodejs/node
that referenced
this pull request
Nov 11, 2026
Signed-off-by: Filip Skokan <[email protected]> PR-URL: #67229 Refs: nodejs/undici#6152 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95
pushed a commit
to nodejs/node
that referenced
this pull request
Nov 12, 2026
Signed-off-by: Filip Skokan <[email protected]> PR-URL: #67229 Refs: nodejs/undici#6152 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95
pushed a commit
to nodejs/node
that referenced
this pull request
Nov 12, 2026
Signed-off-by: Filip Skokan <[email protected]> PR-URL: #67229 Refs: nodejs/undici#6152 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes missing
fetch()WPT results for Node.js 26+ in the daily WPT reports. With this in place they'll pop back in with the undici update landing on those release lines that includes it.Handles new WPT startup messages and subtest failures without a stack.