Remove the esm wrapper, rely on commonjs autodetection#599
Merged
Conversation
dnlup
approved these changes
Mar 16, 2021
ronag
approved these changes
Mar 16, 2021
mcollina
force-pushed
the
support-named-exports
branch
from
1489bb3 to
ff6453c
Compare
Member
Author
|
rebased. Lmk if you are still good to land |
Codecov Report
@@ Coverage Diff @@
## main #599 +/- ##
=======================================
Coverage 99.16% 99.16%
=======================================
Files 16 16
Lines 1444 1444
=======================================
Hits 1432 1432
Misses 12 12
Continue to review full report at Codecov.
|
dnlup
approved these changes
Mar 16, 2021
Contributor
dnlup
left a comment
dnlup
left a comment
There was a problem hiding this comment.
LGTM
Should we squash the commits?
Member
Author
|
I'll squash on landing. |
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
* Remove the esm wrapper, rely on commonjs autodetection Fixes nodejs#598
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #598