Feat: Agent connect/disconnect events#558
Merged
mcollina merged 4 commits intonodejs:masterfrom Feb 19, 2021
Merged
Conversation
added 4 commits
February 19, 2021 11:17
Extend EventEmitter class from within Agent and define support for the connect and disconnect events. ✅ Closes: nodejs#522
Provide minimum set of tests for connect/disconnect events for the Agent class. ✅ Closes: nodejs#522
Disconnect event listener should be removed from the pool/client (acquired through the Agent instance) when instance of the Agent class is destroyed. ✅ Closes: nodejs#522
Provide the tests for the Agent get method, checking weather the pool is instance of Client or Pool class. ✅ Closes: nodejs#522
ronag
approved these changes
Feb 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ Closes: #522
poolinstance returned from the Agentgetmethod.@ronag If any changes are required prior to merging these changes, I'll be more than glad to contribute.