Merged
Conversation
Fixes: #432
szmarczak
reviewed
Sep 23, 2020
| class TrailerMismatchError extends UndiciError { | ||
| constructor (message) { | ||
| super(message) | ||
| Error.captureStackTrace(this, TrailerMismatchError) |
Member
Author
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
But UndiciError extends Error, so isn't .stack generated automatically?
Member
Author
There was a problem hiding this comment.
I'm actually unsure why this is necessary but given the best practices I've been able to read it seems to be the correct way...
Member
Author
There was a problem hiding this comment.
See the example from MDN:
class CustomError extends Error {
constructor(foo = 'bar', ...params) {
// Pass remaining arguments (including vendor specific ones) to parent constructor
super(...params)
// Maintains proper stack trace for where our error was thrown (only available on V8)
if (Error.captureStackTrace) {
Error.captureStackTrace(this, CustomError)
}
this.name = 'CustomError'
// Custom debugging information
this.foo = foo
this.date = new Date()
}
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #432