Conversation
Contributor
Author
|
I am kind of dissappointed of the latest spec. |
mozfreddyb
reviewed
Jun 30, 2025
mozfreddyb
reviewed
Jun 30, 2025
Contributor
Author
|
I think we can review and merge it. The problems with base64url are well known. |
KhafraDev
approved these changes
Jul 12, 2025
gurgunday
approved these changes
Aug 9, 2025
KhafraDev
reviewed
Aug 15, 2025
Co-authored-by: Khafra <[email protected]>
KhafraDev
approved these changes
Aug 17, 2025
slagiewka
pushed a commit
to slagiewka/undici
that referenced
this pull request
Feb 14, 2026
* feat: extract sri from fetch, upgrade to latest spec * improve coverage * fix * remove ts-check * Apply suggestions from code review * fix * switch order according to my change in the spec * fix comment * imrprove with better helper functions * rename sri to subresource-integrity * fix * Update test/fetch/integrity.js Co-authored-by: Khafra <[email protected]> * adapt --------- Co-authored-by: Khafra <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.