Move pool and client stats into util/stats

nodejs · metcoder95 · May 9, 2025 · Apr 12, 2025 · Apr 12, 2025 · Apr 12, 2025
commit ab942e49f42858f639ac6ab064deb05b1ac993da
diff --git a/lib/dispatcher/client-stats.js b/lib/dispatcher/client-stats.js
diff --git a/lib/dispatcher/client.js b/lib/dispatcher/client.js
@@ -4,10 +4,10 @@ const assert = require('node:assert')
 const net = require('node:net')
 const http = require('node:http')
 const util = require('../core/util.js')
+const { ClientStats } = require('../util/stats.js')
 const { channels } = require('../core/diagnostics.js')
 const Request = require('../core/request.js')
 const DispatcherBase = require('./dispatcher-base')
-const ClientStats = require('./client-stats')
 const {
   InvalidArgumentError,
   InformationalError,

diff --git a/lib/dispatcher/pool-base.js b/lib/dispatcher/pool-base.js
@@ -1,9 +1,9 @@
 'use strict'
 
+const { PoolStats } = require('../util/stats.js')
 const DispatcherBase = require('./dispatcher-base')
 const FixedQueue = require('./fixed-queue')
 const { kConnected, kSize, kRunning, kPending, kQueued, kBusy, kFree, kUrl, kClose, kDestroy, kDispatch, kStats } = require('../core/symbols')
-const PoolStats = require('./pool-stats')
 
 const kClients = Symbol('clients')
 const kNeedDrain = Symbol('needDrain')

diff --git a/lib/dispatcher/pool-stats.js b/lib/dispatcher/pool-stats.js
diff --git a/lib/util/stats.js b/lib/util/stats.js
@@ -0,0 +1,67 @@
+'use strict'
+
+const {
+  kConnected,
+  kPending,
+  kRunning,
+  kSize,
+  kFree,
+  kQueued
+} = require('../core/symbols')
+
+const kPool = Symbol('pool')
+const kClient = Symbol('client')
+
+class ClientStats {
+  constructor (client) {
+    this[kClient] = client
+  }
+
+  get connected () {
+    return this[kClient][kConnected]
+  }
+
+  get pending () {
+    return this[kClient][kPending]
+  }
+
+  get running () {
+    return this[kClient][kRunning]
+  }
+
+  get size () {
+    return this[kClient][kSize]
+  }
+}
+
+class PoolStats {
+  constructor (pool) {
+    this[kPool] = pool
+  }
+
+  get connected () {
+    return this[kPool][kConnected]
+  }
+
+  get free () {
+    return this[kPool][kFree]
+  }
+
+  get pending () {
+    return this[kPool][kPending]
+  }
+
+  get queued () {
+    return this[kPool][kQueued]
+  }
+
+  get running () {
+    return this[kPool][kRunning]
+  }
+
+  get size () {
+    return this[kPool][kSize]
+  }
+}
+
+module.exports = { ClientStats, PoolStats }
diff --git a/mise.toml b/mise.toml
@@ -0,0 +1,2 @@
+[tools]
+node = "22"