Merged
Conversation
ronag
requested changes
Sep 7, 2024
Member
|
Would it maybe be better to use jsdoc types rather than separate type definition files? @mcollina |
metcoder95
reviewed
Sep 8, 2024
Member
I think using type definitions are in line with the rest of the codebase, and therefore the correct implementation. If we want to migrate to a jsdoc-generated world, let's discuss in another issue! |
ronag
reviewed
Sep 10, 2024
metcoder95
reviewed
Sep 10, 2024
Member
ronag
reviewed
Sep 11, 2024
ronag
reviewed
Sep 11, 2024
flakey5
force-pushed
the
flakey5/3231
branch
2 times, most recently
from
e07e3ec to
938fa7a
Compare
Implements bare-bones http caching as per rfc9111 Closes nodejs#3231 Closes nodejs#2760 Closes nodejs#2256 Closes nodejs#1146 Co-authored-by: Carlos Fuentes <[email protected]> Co-authored-by: Robert Nagy <[email protected]> Co-authored-by: Isak Törnros <[email protected]> Signed-off-by: flakey5 <[email protected]>
flakey5
force-pushed
the
flakey5/3231
branch
from
938fa7a to
f69a8b2
Compare
Signed-off-by: flakey5 <[email protected]>
mcollina
requested changes
Sep 14, 2024
Signed-off-by: flakey5 <[email protected]>
ronag
reviewed
Sep 15, 2024
Signed-off-by: flakey5 <[email protected]>
Co-authored-by: Robert Nagy <[email protected]>
metcoder95
reviewed
Sep 16, 2024
Co-authored-by: Carlos Fuentes <[email protected]>
Signed-off-by: flakey5 <[email protected]>
Signed-off-by: flakey5 <[email protected]>
Uzlopak
reviewed
Sep 16, 2024
Uzlopak
reviewed
Sep 16, 2024
Uzlopak
reviewed
Sep 16, 2024
Contributor
Uzlopak
left a comment
Uzlopak
left a comment
There was a problem hiding this comment.
headers could be null or undefined
Uzlopak
reviewed
Sep 16, 2024
Co-authored-by: Aras Abbasi <[email protected]>
Co-authored-by: Aras Abbasi <[email protected]>
Signed-off-by: flakey5 <[email protected]>
Co-authored-by: Aras Abbasi <[email protected]>
Co-authored-by: Aras Abbasi <[email protected]>
Signed-off-by: flakey5 <[email protected]>
Contributor
|
I will review it shortly ;) |
SukkaW
reviewed
Oct 14, 2024
| // https://www.rfc-editor.org/rfc/rfc9111.html#name-age | ||
| const age = Math.round((Date.now() - value.cachedAt) / 1000) | ||
|
|
||
| value.rawHeaders.push(AGE_HEADER, Buffer.from(`${age}`)) |
Contributor
There was a problem hiding this comment.
Suggested change
| value.rawHeaders.push(AGE_HEADER, Buffer.from(`${age}`)) | |
| value.rawHeaders.push(AGE_HEADER, Buffer.from(age)) |
SukkaW
reviewed
Oct 14, 2024
| const CacheRevalidationHandler = require('../handler/cache-revalidation-handler') | ||
| const { UNSAFE_METHODS } = require('../util/cache.js') | ||
|
|
||
| const AGE_HEADER = Buffer.from('age') |
Contributor
There was a problem hiding this comment.
I am not entirely sure why age here is lowercased. If it is Age, we can re-use getWellKnownHeaderBuffer.
Member
|
Guys. Please stop with the nits for now and open follow up PRs.we need to land this. |
Uzlopak
reviewed
Oct 14, 2024
Co-authored-by: Aras Abbasi <[email protected]>
Uzlopak
reviewed
Oct 14, 2024
Co-authored-by: Aras Abbasi <[email protected]>
Uzlopak
reviewed
Oct 14, 2024
Uzlopak
reviewed
Oct 14, 2024
Uzlopak
reviewed
Oct 14, 2024
Uzlopak
approved these changes
Oct 14, 2024
Contributor
Uzlopak
left a comment
Uzlopak
left a comment
There was a problem hiding this comment.
I dont see any obvious code smell any more. :)
LGTM
Contributor
|
Unrelated Test is flaky. see #3731 |
Merged
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements bare-bones opt-in http caching as per rfc9111. Bare-bones in this case means what's required by the spec and a few extra bits, with more coming in future prs.
Opening as a draft since there's still some more work to be done (mostly tests, but a bit more functionality-wise)No request cache directives are supported at this time, this will come later.
Response caching directives supported:
publicprivates-maxagemax-ageExpiresheaderno-cacheno-storestale-while-revalidateThis relates to...
Closes #3231
Closes #2760
Closes #2256
Closes #1146
Changes
Features
Bug Fixes
n/a
Breaking Changes and Deprecations
n/a
Status