fix: interceptors.d.ts has no default export #3332
Merged
+16
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uzlopak
commented
Jun 17, 2024
|
|
||
| import { File } from './file' | ||
| import { SpecIterator, SpecIterableIterator } from './fetch' | ||
| import { SpecIterableIterator } from './fetch' |
Uzlopak
commented
Jun 17, 2024
| opts?: ConvertToIntOpts, | ||
| prefix: string, | ||
| argument: string | ||
| opts?: ConvertToIntOpts |
Contributor
Author
There was a problem hiding this comment.
tsc reported that after optional paramaters there can not be mandatory parameters.
Compared with implementation and the following arguments are not existing.
Uzlopak
commented
Jun 17, 2024
| "test:tdd": "borp --expose-gc -p \"test/*.js\"", | ||
| "test:tdd:node-test": "borp -p \"test/node-test/**/*.js\" -w", | ||
| "test:typescript": "tsd && tsc --skipLibCheck test/imports/undici-import.ts", | ||
| "test:typescript": "tsd && tsc test/imports/undici-import.ts --typeRoots ./types && tsc ./types/*.d.ts --noEmit --typeRoots ./types", |
Contributor
Author
There was a problem hiding this comment.
eslint is throwing typings errors. to avoid it we simulate an skipLibCheck by pointing to the types folder. this is not nice but eslint sucks. So this is a low level solution.
Merged
This was referenced Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3330
We need to remove skipLibCheck to throw the error. Now we can detect the bug.