websocket: use FixedQueue instead of Set#3283
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
4dfe172 to
cc4f3de
Compare
ronag
left a comment
There was a problem hiding this comment.
Why not fixed_queue from node core?
There is no particular reason for this. |
|
In this use case, I prefer the simple linkedlist; Initialization of the array of 2048 entries takes time :) |
I think that is amortized quite quickly... |
What about? |
|
If it was about sending data, it would be 1.2 times faster since we changed to zero-copy. |
|
Yeah, sending messages. Do you have the data to backup the 1.2x faster claim? |
|
okey, look this |
Rewrite with fixed_queue! |
KhafraDev
left a comment
There was a problem hiding this comment.
why is queue being lazily created?
|
I don't have time right now, so I will rewrite it in another PR. |
This reverts commit 0e415b2.
8667b10 to
c05988c
Compare
468d2d0 to
a88052b
Compare
Co-authored-by: Khafra <[email protected]>
@KhafraDev