perf: Remove double-stringify in setCookie#2980
Merged
KhafraDev merged 2 commits intonodejs:mainfrom Mar 22, 2024
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Was perusing the code and spotted a double call to 'stringify' in setCookie
Rationale
Didn't seem logical to run stringify multiple times on the same value as this might be an expensive operation behind the scenes.
Changes
Removed the additional call to stringify
Features
N/A
Bug Fixes
N/A
Breaking Changes and Deprecations
N/A
Status