fix: set default idle timeout to 4 seconds#279
Merged
Conversation
Node HTTP server seem to have a default of 5 seconds and we should be below that. Fixes: #276
Member
Author
ronag
commented
Jul 30, 2020
lib/client.js
Outdated
| // Set timeout to half of hint to account for timing inaccuracies. | ||
| client[kKeepAliveTimeout] = Math.min(keepAliveTimeout - 500, client[kIdleTimeout]) | ||
| let keepAliveTimeout = Number(m[1]) * 1000 | ||
| keepAliveTimeout = keepAliveTimeout > 2000 ? keepAliveTimeout - 1000 : keepAliveTimeout / 2 |
Member
Author
There was a problem hiding this comment.
We do 1s as to take into account bad rounding from ms to s on server side.
4 tasks
mcollina
approved these changes
Jul 30, 2020
Member
mcollina
left a comment
mcollina
left a comment
There was a problem hiding this comment.
lgtm. I'm not 100% conviced about this, as keeping it alive for a long time is typically worthwhile.
Member
Author
Not convinced either... but not sure what the alternative is... both Node and Cloudfront seem to have quite short keep alive times. |
Member
|
Let's go for it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node HTTP server seem to have a default of 5 seconds and
we should be below that.
Fixes: #276