fix: webidl.brandcheck non strict should throw#2683
Merged
mcollina merged 7 commits intonodejs:mainfrom Feb 5, 2024
Merged
Conversation
Uzlopak
force-pushed
the
fix-webidl-brandcheck
branch
from
0b8d8e3 to
678f0f4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2683 +/- ##
==========================================
- Coverage 85.54% 85.29% -0.26%
==========================================
Files 76 84 +8
Lines 6858 7582 +724
==========================================
+ Hits 5867 6467 +600
- Misses 991 1115 +124 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
KhafraDev
approved these changes
Feb 1, 2024
Member
|
A test would be nice. |
Contributor
Author
|
@mcollina |
KhafraDev
reviewed
Feb 3, 2024
Contributor
Author
|
added for the other three cookie functions tests. |
Contributor
Author
|
What do you think about having an additional brandCheckLax webidl method for performance reasons? |
Member
|
👎 |
Contributor
Author
|
Ok, but this PR is fine so far, right? I guess we could merge it then after the security release? |
Member
|
yep, waiting on the security release |
kodiakhq Bot
referenced
this pull request
in X-oss-byte/Canary-nextjs
Feb 8, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [undici](https://undici.nodejs.org) ([source](https://togithub.com/nodejs/undici)) | [`6.6.0` -> `6.6.2`](https://renovatebot.com/diffs/npm/undici/6.6.0/6.6.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>nodejs/undici (undici)</summary> ### [`v6.6.2`](https://togithub.com/nodejs/undici/releases/tag/v6.6.2) [Compare Source](https://togithub.com/nodejs/undici/compare/v6.6.1...v6.6.2) #### What's Changed - fix: webidl.brandcheck non strict should throw by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/nodejs/undici/pull/2683](https://togithub.com/nodejs/undici/pull/2683) - fix: expose EventSource for nodejs by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/nodejs/undici/pull/2645](https://togithub.com/nodejs/undici/pull/2645) - test: more information from debug tests by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/nodejs/undici/pull/2695](https://togithub.com/nodejs/undici/pull/2695) - Fix broken test on linux by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/nodejs/undici/pull/2699](https://togithub.com/nodejs/undici/pull/2699) - fix: fix the linux patch by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/nodejs/undici/pull/2703](https://togithub.com/nodejs/undici/pull/2703) - test(wpt): mark timed out tests as 'failed' by [@​rossilor95](https://togithub.com/rossilor95) in [https://github.com/nodejs/undici/pull/2644](https://togithub.com/nodejs/undici/pull/2644) - build(deps-dev): bump borp from 0.5.0 to 0.9.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/nodejs/undici/pull/2702](https://togithub.com/nodejs/undici/pull/2702) - perf: use insertion sort algorithm by [@​tsctx](https://togithub.com/tsctx) in [https://github.com/nodejs/undici/pull/2706](https://togithub.com/nodejs/undici/pull/2706) - fix: run node tests on merge by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/nodejs/undici/pull/2707](https://togithub.com/nodejs/undici/pull/2707) #### New Contributors - [@​rossilor95](https://togithub.com/rossilor95) made their first contribution in [https://github.com/nodejs/undici/pull/2644](https://togithub.com/nodejs/undici/pull/2644) **Full Changelog**: nodejs/undici@v6.6.1...v6.6.2 ### [`v6.6.1`](https://togithub.com/nodejs/undici/releases/tag/v6.6.1) [Compare Source](https://togithub.com/nodejs/undici/compare/v6.6.0...v6.6.1) ####⚠️ Security Release⚠️ Details on the vulnerabilities fixed will be shared in the next couple of days. #### What's Changed - fix: flaky debug test by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/nodejs/undici/pull/2687](https://togithub.com/nodejs/undici/pull/2687) - build(deps): bump github/codeql-action from 3.22.12 to 3.23.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/nodejs/undici/pull/2688](https://togithub.com/nodejs/undici/pull/2688) - build(deps): bump actions/dependency-review-action from 3.1.0 to 4.0.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/nodejs/undici/pull/2689](https://togithub.com/nodejs/undici/pull/2689) - fix: ci pipeline warnings by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/nodejs/undici/pull/2685](https://togithub.com/nodejs/undici/pull/2685) - perf: optimize Iterator by [@​tsctx](https://togithub.com/tsctx) in [https://github.com/nodejs/undici/pull/2692](https://togithub.com/nodejs/undici/pull/2692) **Full Changelog**: nodejs/undici@v6.6.0...v6.6.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/X-oss-byte/Canary-nextjs).
kodiakhq Bot
referenced
this pull request
in ascorbic/unpic-img
Feb 11, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [undici](https://undici.nodejs.org) ([source](https://togithub.com/nodejs/undici)) | [`6.6.0` -> `6.6.2`](https://renovatebot.com/diffs/npm/undici/6.6.0/6.6.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>nodejs/undici (undici)</summary> ### [`v6.6.2`](https://togithub.com/nodejs/undici/releases/tag/v6.6.2) [Compare Source](https://togithub.com/nodejs/undici/compare/v6.6.1...v6.6.2) #### What's Changed - fix: webidl.brandcheck non strict should throw by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/nodejs/undici/pull/2683](https://togithub.com/nodejs/undici/pull/2683) - fix: expose EventSource for nodejs by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/nodejs/undici/pull/2645](https://togithub.com/nodejs/undici/pull/2645) - test: more information from debug tests by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/nodejs/undici/pull/2695](https://togithub.com/nodejs/undici/pull/2695) - Fix broken test on linux by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/nodejs/undici/pull/2699](https://togithub.com/nodejs/undici/pull/2699) - fix: fix the linux patch by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/nodejs/undici/pull/2703](https://togithub.com/nodejs/undici/pull/2703) - test(wpt): mark timed out tests as 'failed' by [@​rossilor95](https://togithub.com/rossilor95) in [https://github.com/nodejs/undici/pull/2644](https://togithub.com/nodejs/undici/pull/2644) - build(deps-dev): bump borp from 0.5.0 to 0.9.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/nodejs/undici/pull/2702](https://togithub.com/nodejs/undici/pull/2702) - perf: use insertion sort algorithm by [@​tsctx](https://togithub.com/tsctx) in [https://github.com/nodejs/undici/pull/2706](https://togithub.com/nodejs/undici/pull/2706) - fix: run node tests on merge by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/nodejs/undici/pull/2707](https://togithub.com/nodejs/undici/pull/2707) #### New Contributors - [@​rossilor95](https://togithub.com/rossilor95) made their first contribution in [https://github.com/nodejs/undici/pull/2644](https://togithub.com/nodejs/undici/pull/2644) **Full Changelog**: nodejs/undici@v6.6.1...v6.6.2 ### [`v6.6.1`](https://togithub.com/nodejs/undici/releases/tag/v6.6.1) [Compare Source](https://togithub.com/nodejs/undici/compare/v6.6.0...v6.6.1) ####⚠️ Security Release⚠️ Details on the vulnerabilities fixed will be shared in the next couple of days. #### What's Changed - fix: flaky debug test by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/nodejs/undici/pull/2687](https://togithub.com/nodejs/undici/pull/2687) - build(deps): bump github/codeql-action from 3.22.12 to 3.23.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/nodejs/undici/pull/2688](https://togithub.com/nodejs/undici/pull/2688) - build(deps): bump actions/dependency-review-action from 3.1.0 to 4.0.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/nodejs/undici/pull/2689](https://togithub.com/nodejs/undici/pull/2689) - fix: ci pipeline warnings by [@​Uzlopak](https://togithub.com/Uzlopak) in [https://github.com/nodejs/undici/pull/2685](https://togithub.com/nodejs/undici/pull/2685) - perf: optimize Iterator by [@​tsctx](https://togithub.com/tsctx) in [https://github.com/nodejs/undici/pull/2692](https://togithub.com/nodejs/undici/pull/2692) **Full Changelog**: nodejs/undici@v6.6.0...v6.6.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 9pm on sunday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ascorbic/unpic-img). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 21, 2024
* fix: webidl.brandcheck non strict should throw * add brandcheck test * add one more test case * one more test for globalThis.Headers * remove test * add brandcheck for all cases
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
* fix: webidl.brandcheck non strict should throw * add brandcheck test * add one more test case * one more test for globalThis.Headers * remove test * add brandcheck for all cases
create-app-token-action-releaser Bot
pushed a commit
to actions/create-github-app-token
that referenced
this pull request
Mar 1, 2024
## [1.8.2](v1.8.1...v1.8.2) (2024-03-01) ### Bug Fixes * **deps:** bump the production-dependencies group with 3 updates ([#107](#107)) ([f83fb27](f83fb27)), closes [#579](https://github.com/actions/create-github-app-token/issues/579) [#579](https://github.com/actions/create-github-app-token/issues/579) [#576](https://github.com/actions/create-github-app-token/issues/576) [#577](https://github.com/actions/create-github-app-token/issues/577) [#574](https://github.com/actions/create-github-app-token/issues/574) [#572](https://github.com/actions/create-github-app-token/issues/572) [#571](https://github.com/actions/create-github-app-token/issues/571) [#567](https://github.com/actions/create-github-app-token/issues/567) [#681](https://github.com/actions/create-github-app-token/issues/681) [#678](https://github.com/actions/create-github-app-token/issues/678) [#667](https://github.com/actions/create-github-app-token/issues/667) [#681](https://github.com/actions/create-github-app-token/issues/681) [#680](https://github.com/actions/create-github-app-token/issues/680) [#609](https://github.com/actions/create-github-app-token/issues/609) [#678](https://github.com/actions/create-github-app-token/issues/678) [#676](https://github.com/actions/create-github-app-token/issues/676) [#673](https://github.com/actions/create-github-app-token/issues/673) [#669](https://github.com/actions/create-github-app-token/issues/669) [#667](https://github.com/actions/create-github-app-token/issues/667) [#671](https://github.com/actions/create-github-app-token/issues/671) [nodejs/undici#2683](nodejs/undici#2683) [nodejs/undici#2645](nodejs/undici#2645) [nodejs/undici#2695](nodejs/undici#2695) [nodejs/undici#2699](nodejs/undici#2699) [nodejs/undici#2703](nodejs/undici#2703) [nodejs/undici#2644](nodejs/undici#2644) [nodejs/undici#2702](nodejs/undici#2702) [nodejs/undici#2706](nodejs/undici#2706) [nodejs/undici#2707](nodejs/undici#2707) [nodejs/undici#2644](nodejs/undici#2644) [#2707](https://github.com/actions/create-github-app-token/issues/2707) [#2706](https://github.com/actions/create-github-app-token/issues/2706) [#2702](https://github.com/actions/create-github-app-token/issues/2702) [#2644](https://github.com/actions/create-github-app-token/issues/2644) [#2703](https://github.com/actions/create-github-app-token/issues/2703) [#2699](https://github.com/actions/create-github-app-token/issues/2699) [#2695](https://github.com/actions/create-github-app-token/issues/2695) [#2645](https://github.com/actions/create-github-app-token/issues/2645) [#2683](https://github.com/actions/create-github-app-token/issues/2683)
bloopy-boi Bot
added a commit
to h3mmy/bloopyboi
that referenced
this pull request
Mar 1, 2024
](https://renovatebot.com){kind=link}
…1.8.2 (#163) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/create-github-app-token](https://togithub.com/actions/create-github-app-token) | action | patch | `v1.8.1` -> `v1.8.2` | --- ### Release Notes <details> <summary>actions/create-github-app-token (actions/create-github-app-token)</summary> ### [`v1.8.2`](https://togithub.com/actions/create-github-app-token/releases/tag/v1.8.2) [Compare Source](https://togithub.com/actions/create-github-app-token/compare/v1.8.1...v1.8.2) ##### Bug Fixes - **deps:** bump the production-dependencies group with 3 updates ([#​107](https://togithub.com/actions/create-github-app-token/issues/107)) ([f83fb27](https://togithub.com/actions/create-github-app-token/commit/f83fb279aa2bc96a80fac0b8cb97b369ae18334f)), closes [#​579](https://togithub.com/actions/create-github-app-token/issues/579) [#​579](https://togithub.com/actions/create-github-app-token/issues/579) [#​576](https://togithub.com/actions/create-github-app-token/issues/576) [#​577](https://togithub.com/actions/create-github-app-token/issues/577) [#​574](https://togithub.com/actions/create-github-app-token/issues/574) [#​572](https://togithub.com/actions/create-github-app-token/issues/572) [#​571](https://togithub.com/actions/create-github-app-token/issues/571) [#​567](https://togithub.com/actions/create-github-app-token/issues/567) [#​681](https://togithub.com/actions/create-github-app-token/issues/681) [#​678](https://togithub.com/actions/create-github-app-token/issues/678) [#​667](https://togithub.com/actions/create-github-app-token/issues/667) [#​681](https://togithub.com/actions/create-github-app-token/issues/681) [#​680](https://togithub.com/actions/create-github-app-token/issues/680) [#​609](https://togithub.com/actions/create-github-app-token/issues/609) [#​678](https://togithub.com/actions/create-github-app-token/issues/678) [#​676](https://togithub.com/actions/create-github-app-token/issues/676) [#​673](https://togithub.com/actions/create-github-app-token/issues/673) [#​669](https://togithub.com/actions/create-github-app-token/issues/669) [#​667](https://togithub.com/actions/create-github-app-token/issues/667) [#​671](https://togithub.com/actions/create-github-app-token/issues/671) [nodejs/undici#2683](https://togithub.com/nodejs/undici/issues/2683) [nodejs/undici#2645](https://togithub.com/nodejs/undici/issues/2645) [nodejs/undici#2695](https://togithub.com/nodejs/undici/issues/2695) [nodejs/undici#2699](https://togithub.com/nodejs/undici/issues/2699) [nodejs/undici#2703](https://togithub.com/nodejs/undici/issues/2703) [nodejs/undici#2644](https://togithub.com/nodejs/undici/issues/2644) [nodejs/undici#2702](https://togithub.com/nodejs/undici/issues/2702) [nodejs/undici#2706](https://togithub.com/nodejs/undici/issues/2706) [nodejs/undici#2707](https://togithub.com/nodejs/undici/issues/2707) [nodejs/undici#2644](https://togithub.com/nodejs/undici/issues/2644) [#​2707](https://togithub.com/actions/create-github-app-token/issues/2707) [#​2706](https://togithub.com/actions/create-github-app-token/issues/2706) [#​2702](https://togithub.com/actions/create-github-app-token/issues/2702) [#​2644](https://togithub.com/actions/create-github-app-token/issues/2644) [#​2703](https://togithub.com/actions/create-github-app-token/issues/2703) [#​2699](https://togithub.com/actions/create-github-app-token/issues/2699) [#​2695](https://togithub.com/actions/create-github-app-token/issues/2695) [#​2645](https://togithub.com/actions/create-github-app-token/issues/2645) [#​2683](https://togithub.com/actions/create-github-app-token/issues/2683) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMjEuMyIsInVwZGF0ZWRJblZlciI6IjM3LjIyMS4zIiwidGFyZ2V0QnJhbmNoIjoiZGV2In0=--> Co-authored-by: bloopy-boi[bot] <98279278+bloopy-boi[bot]@users.noreply.github.com>
It is very strange, that in case of strict: false brandCheck would not throw, but in strict cases it would throw.
We use the non strict brandCheck e.g.
undici/lib/cookies/index.js
Line 56 in 0808a72
The non strict check is basically a no op, as nothing happens with the result. I assume this was just an oversight.
I would actually recommend for performance reasons to implement a webidl.brandCheckLax (or something like that) and make webidl.brandCheck only handle strict cases.
This relates to...
Rationale
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status