fix: adjust number of arguments in Response.json()
#2225
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronag
approved these changes
Aug 25, 2023
KhafraDev
requested changes
Aug 25, 2023
Member
KhafraDev
left a comment
KhafraDev
left a comment
There was a problem hiding this comment.
WPT fails because of this (the test was the reason for this change originally). Maybe the tests need to be updated.
Started \undici\test\wpt\tests\fetch\api\idlharness.any.js
{
status: 1,
name: 'Response interface: operation json(any, optional ResponseInit)',
message: 'assert_equals: property has wrong .length expected 0 but got 1',
stack: 'Error\n' +
' at get_stack (evalmachine.<anonymous>:4534:21)\n' +
' at new AssertionError (evalmachine.<anonymous>:4527:22)\n' +
' at assert (evalmachine.<anonymous>:4511:19)\n' +
' at assert_equals (evalmachine.<anonymous>:1516:9)\n' +
' at assert_wrapper (evalmachine.<anonymous>:1436:30)\n' +
' at IdlInterface.do_member_operation_asserts (evalmachine.<anonymous>:2363:5)\n' +
' at IdlInterface.<anonymous> (evalmachine.<anonymous>:2309:14)\n' +
' at Test.step (evalmachine.<anonymous>:2595:25)\n' +
' at IdlInterface.test_member_operation (evalmachine.<anonymous>:2257:12)\n' +
' at IdlInterface.test_members (evalmachine.<anonymous>:2720:26)'
}
Member
|
yeah, it looks like the tests were updated at some point, https://wpt.fyi/results/fetch/api/idlharness.any.html?label=master&label=experimental&product=chrome&product=firefox&product=safari&product=node.js&product=deno&aligned I updated the WPTs and fixed this in my PR below, with credit |
Merged
Member
|
Can this be closed? |
Member
Author
|
Yes. #2226 contains the fix and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
datais not optionalRefs: https://fetch.spec.whatwg.org/#ref-for-dom-response-json