feat: add all File WPTs#1687
Merged
mcollina merged 1 commit intonodejs:mainfrom Oct 7, 2022
Merged
Conversation
Member
No, let's do it. |
Member
Author
|
if it is made a global, should FileReader also be implemented? |
Member
|
I think we should implement that interface anyway. |
Contributor
|
I don't think the FileReader is necessary. We have read methods on the blob itself I consider it to be kind of legacy now |
Member
Author
|
I think adding it is good for the same reason that It also allows us to enable the idlharness for File (the alternative is disabling ~100 tests) which allowed me to find 2 minor bugs in the File implementation. It also prevents regressions in the future, which is great. |
metcoder95
pushed a commit
to metcoder95/undici
that referenced
this pull request
Dec 26, 2022
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
new File([new String('bits')], 'dummy')After this I don't think there's any reason not to make
Filea global in node?+95 tests, no failures. All test files are from https://github.com/web-platform-tests/wpt/tree/master/FileAPI/file
p.s. sorry for all the PRs lately