chore: revert #1349#1408
Merged
mcollina merged 1 commit intonodejs:mainfrom May 3, 2022
Fdawgs:chore/lints
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1408 +/- ##
=======================================
Coverage 94.28% 94.28%
=======================================
Files 47 47
Lines 4250 4250
=======================================
Hits 4007 4007
Misses 243 243 Continue to review full report at Codecov.
|
mcollina
approved these changes
May 3, 2022
Member
mcollina
left a comment
mcollina
left a comment
There was a problem hiding this comment.
thanks, this was very annoying.
LGTM
KhafraDev
pushed a commit
to KhafraDev/undici
that referenced
this pull request
Jun 23, 2022
metcoder95
pushed a commit
to metcoder95/undici
that referenced
this pull request
Dec 26, 2022
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was nothing wrong with the original pre-commit hook. The only thing #1349 does is introduce an extra dependency that needs to be downloaded (which could be compromised down the road).