Conversation
Codecov Report
@@ Coverage Diff @@
## main #1276 +/- ##
==========================================
+ Coverage 94.11% 96.48% +2.37%
==========================================
Files 44 33 -11
Lines 4093 2562 -1531
==========================================
- Hits 3852 2472 -1380
+ Misses 241 90 -151
Continue to review full report at Codecov.
|
Don't start decoding the body before headers and status has been processed. Fixes: #1271
mcollina
requested changes
Mar 12, 2022
Member
mcollina
left a comment
mcollina
left a comment
There was a problem hiding this comment.
Can you please add a unit test?
Member
Author
|
@minas90 Would you mind helping with a test? |
Member
Author
|
Maybe @KhafraDev can help with test? |
Member
|
I couldn't replicate the issue |
KhafraDev
pushed a commit
to KhafraDev/undici
that referenced
this pull request
Jun 23, 2022
* fix: lazy decode body Don't start decoding the body before headers and status has been processed. Fixes: nodejs#1271 * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup
metcoder95
pushed a commit
to metcoder95/undici
that referenced
this pull request
Dec 26, 2022
* fix: lazy decode body Don't start decoding the body before headers and status has been processed. Fixes: nodejs#1271 * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
* fix: lazy decode body Don't start decoding the body before headers and status has been processed. Fixes: nodejs#1271 * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't start prefetching the body before headers and status
has been processed.
Fixes: #1271