feat(MockInterceptor): add support for callbacks on reply#1200
Merged
mcollina merged 5 commits intonodejs:mainfrom Feb 6, 2022
Merged
feat(MockInterceptor): add support for callbacks on reply#1200mcollina merged 5 commits intonodejs:mainfrom
reply#1200mcollina merged 5 commits intonodejs:mainfrom
Conversation
4c48e34 to
103847b
Compare
103847b to
8663895
Compare
mcollina
requested changes
Feb 3, 2022
Member
mcollina
left a comment
There was a problem hiding this comment.
Can you please add a unit test?
Codecov Report
@@ Coverage Diff @@
## main #1200 +/- ##
=======================================
Coverage 93.73% 93.73%
=======================================
Files 43 43
Lines 4023 4023
=======================================
Hits 3771 3771
Misses 252 252
Continue to review full report at Codecov.
|
mcollina
requested changes
Feb 4, 2022
Member
mcollina
left a comment
There was a problem hiding this comment.
Good work!
Could you:
- add a test for the types? we use tsd!
- update the documentation
mcollina
reviewed
Feb 5, 2022
Member
mcollina
left a comment
There was a problem hiding this comment.
Good work! one final question
38fd808 to
efe6b7d
Compare
Closed
KhafraDev
pushed a commit
to KhafraDev/undici
that referenced
this pull request
Jun 23, 2022
metcoder95
pushed a commit
to metcoder95/undici
that referenced
this pull request
Dec 26, 2022
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the ability to have callbacks when replying to a mocked requests, similar to how nock enables callbacks for responses. This is especially helpful for situations where the response depends on certain request options.
Example of how it can be used: