types: align RequestInit types with lib.dom.ts#1199
Conversation
suneettipirneni
force-pushed
the
types/dom-requestinit
branch
from
56210da to
46ed723
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1199 +/- ##
==========================================
- Coverage 93.73% 93.43% -0.31%
==========================================
Files 43 43
Lines 4023 4052 +29
==========================================
+ Hits 3771 3786 +15
- Misses 252 266 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Could you add a few assertions for these changes in https://github.com/nodejs/undici/blob/main/test/types/fetch.test-d.ts? |
Ethan-Arrowood
left a comment
Ethan-Arrowood
left a comment
There was a problem hiding this comment.
approving but also like @mcollina comment, please update the assertions in the test file before merging
|
I assume you have prettier/eslint auto enabled in your editor. please revert all of the changes in the .js file as it does not apply to this PR's intended changes. Thank you! |
5 participants
This relates to...
#1172
Rationale
Types for
RequestInitshould be fully compatible with typescript dom types.Changes
Adds all properties to
RequestInitthat were missing based on the typescript dom types. This adjusts theHeaderssubtype to also follow the typescript definitions.Features
N/A
Bug Fixes
closes #1172
Breaking Changes and Deprecations
N/A