Skip to content

Fix import of ProxyAgent#1194

Merged
ronag merged 1 commit intonodejs:mainfrom
RA80533:patch-1
Feb 1, 2022
Merged

Fix import of ProxyAgent#1194
ronag merged 1 commit intonodejs:mainfrom
RA80533:patch-1

Conversation

@RA80533
Copy link
Copy Markdown
Contributor

@RA80533 RA80533 commented Feb 1, 2022

ProxyAgent is imported with the assumption that allowSyntheticDefaultImports is enabled. The aforementioned option is disabled by default. As a result, users are required to enable allowSyntheticDefaultImports in order to have an error-free TypeScript experience.

#1070 (comment)

Copy link
Copy Markdown
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 1, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.71%. Comparing base (2dd3437) to head (28ad02d).
⚠️ Report is 2184 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1194      +/-   ##
==========================================
- Coverage   93.73%   93.71%   -0.03%     
==========================================
  Files          43       43              
  Lines        4023     4023              
==========================================
- Hits         3771     3770       -1     
- Misses        252      253       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag ronag merged commit 5c19579 into nodejs:main Feb 1, 2022
@RA80533 RA80533 deleted the patch-1 branch February 2, 2022 16:47
KhafraDev pushed a commit to KhafraDev/undici that referenced this pull request Jun 23, 2022
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants