Skip to content

fix: add node 17 to test matrix#1091

Closed
ronag wants to merge 1 commit intomainfrom
node17
Closed

fix: add node 17 to test matrix#1091
ronag wants to merge 1 commit intomainfrom
node17

Conversation

@ronag
Copy link
Copy Markdown
Member

@ronag ronag commented Nov 11, 2021

Refs: #1061

@ronag ronag requested a review from mcollina November 11, 2021 07:44
@ronag ronag mentioned this pull request Nov 11, 2021
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 11, 2021

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.73%. Comparing base (3d2ce43) to head (9cec17d).
⚠️ Report is 2249 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1091      +/-   ##
==========================================
- Coverage   95.10%   94.73%   -0.38%     
==========================================
  Files          39       39              
  Lines        3758     3758              
==========================================
- Hits         3574     3560      -14     
- Misses        184      198      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ronag
Copy link
Copy Markdown
Member Author

ronag commented Nov 11, 2021

@mcollina any ideas why it fails on 17?

@ronag ronag closed this Nov 12, 2021
@szmarczak
Copy link
Copy Markdown
Member

Probably #1085 I guess the certificates need to use modern TLS features. No idea how to regenerate them.

@Uzlopak Uzlopak mentioned this pull request Jan 27, 2024
7 tasks
@Uzlopak Uzlopak deleted the node17 branch February 26, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants