chore: small perf improvements (#2661)

Uzlopak · web-flow · commit f1d7ada7eb22 · 2024-01-30T21:00:35.000+01:00
diff --git a/lib/fetch/index.js b/lib/fetch/index.js
@@ -303,19 +303,17 @@ function finalizeAndReportTiming (response, initiatorType = 'other') {
   // global, and cacheState.
   markResourceTiming(
     timingInfo,
-    originalURL,
+    originalURL.href,
     initiatorType,
     globalThis,
     cacheState
   )
 }
 
 // https://w3c.github.io/resource-timing/#dfn-mark-resource-timing
-function markResourceTiming (timingInfo, originalURL, initiatorType, globalThis, cacheState) {
-  if (nodeMajor > 18 || (nodeMajor === 18 && nodeMinor >= 2)) {
-    performance.markResourceTiming(timingInfo, originalURL.href, initiatorType, globalThis, cacheState)
-  }
-}
+const markResourceTiming = (nodeMajor > 18 || (nodeMajor === 18 && nodeMinor >= 2))
+  ? performance.markResourceTiming
+  : () => {}
 
 // https://fetch.spec.whatwg.org/#abort-fetch
 function abortFetch (p, request, responseObject, error) {
@@ -1042,7 +1040,7 @@ function fetchFinale (fetchParams, response) {
       //    and responseStatus.
       if (fetchParams.request.initiatorType != null) {
         // TODO: update markresourcetiming
-        markResourceTiming(timingInfo, fetchParams.request.url, fetchParams.request.initiatorType, globalThis, cacheState, bodyInfo, responseStatus)
+        markResourceTiming(timingInfo, fetchParams.request.url.href, fetchParams.request.initiatorType, globalThis, cacheState, bodyInfo, responseStatus)
       }
     }
 
diff --git a/lib/pool.js b/lib/pool.js
@@ -76,18 +76,17 @@ class Pool extends PoolBase {
   }
 
   [kGetDispatcher] () {
-    let dispatcher = this[kClients].find(dispatcher => !dispatcher[kNeedDrain])
-
-    if (dispatcher) {
-      return dispatcher
+    for (const client of this[kClients]) {
+      if (!client[kNeedDrain]) {
+        return client
+      }
     }
 
     if (!this[kConnections] || this[kClients].length < this[kConnections]) {
-      dispatcher = this[kFactory](this[kUrl], this[kOptions])
+      const dispatcher = this[kFactory](this[kUrl], this[kOptions])
       this[kAddClient](dispatcher)
+      return dispatcher
     }
-
-    return dispatcher
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -76,18 +76,17 @@ class Pool extends PoolBase {`
`76`	`76`	`}`
`77`	`77`
`78`	`78`	`[kGetDispatcher] () {`
`79`		`- let dispatcher = this[kClients].find(dispatcher => !dispatcher[kNeedDrain])`
`80`		`-`
`81`		`- if (dispatcher) {`
`82`		`- return dispatcher`
	`79`	`+ for (const client of this[kClients]) {`
	`80`	`+ if (!client[kNeedDrain]) {`
	`81`	`+ return client`
	`82`	`+ }`
`83`	`83`	`}`
`84`	`84`
`85`	`85`	`if (!this[kConnections] \|\| this[kClients].length < this[kConnections]) {`
`86`		`- dispatcher = this[kFactory](this[kUrl], this[kOptions])`
	`86`	`+ const dispatcher = this[kFactory](this[kUrl], this[kOptions])`
`87`	`87`	`this[kAddClient](dispatcher)`
	`88`	`+ return dispatcher`
`88`	`89`	`}`
`89`		`-`
`90`		`- return dispatcher`
`91`	`90`	`}`
`92`	`91`	`}`
`93`	`92`