fix: onParserTimeout potentially accessing undefined (#4758)

vbfox · web-flow · commit e65fa39309ef · 2026-02-01T12:38:26.000-08:00
In cases where onParserTimeout is called with a weak reference that has already been collected it was throwing an error like: Cannot destructure property 'socket' of 'parser.deref(...)' as it is undefined - Fixes #4755
diff --git a/lib/dispatcher/client-h1.js b/lib/dispatcher/client-h1.js
@@ -735,8 +735,13 @@ class Parser {
   }
 }
 
-function onParserTimeout (parser) {
-  const { socket, timeoutType, client, paused } = parser.deref()
+function onParserTimeout (parserWeakRef) {
+  const parser = parserWeakRef.deref()
+  if (!parser) {
+    return
+  }
+
+  const { socket, timeoutType, client, paused } = parser
 
   if (timeoutType === TIMEOUT_HEADERS) {
     if (!socket[kWriting] || socket.writableNeedDrain || client[kRunning] > 1) {

Original file line number	Diff line number	Diff line change
`@@ -735,8 +735,13 @@ class Parser {`
`735`	`735`	`}`
`736`	`736`	`}`
`737`	`737`
`738`		`-function onParserTimeout (parser) {`
`739`		`- const { socket, timeoutType, client, paused } = parser.deref()`
	`738`	`+function onParserTimeout (parserWeakRef) {`
	`739`	`+ const parser = parserWeakRef.deref()`
	`740`	`+ if (!parser) {`
	`741`	`+ return`
	`742`	`+ }`
	`743`	`+`
	`744`	`+ const { socket, timeoutType, client, paused } = parser`
`740`	`745`
`741`	`746`	`if (timeoutType === TIMEOUT_HEADERS) {`
`742`	`747`	`if (!socket[kWriting] \|\| socket.writableNeedDrain \|\| client[kRunning] > 1) {`