feat(#4086): keep alive on CONNECT

metcoder95 · metcoder95 · commit df5244263866 · 2025-03-30T14:45:18.000+02:00
diff --git a/lib/dispatcher/client-h1.js b/lib/dispatcher/client-h1.js
@@ -1101,7 +1101,7 @@ function writeH1 (client, request) {
     socket[kReset] = true
   }
 
-  if (upgrade || method === 'CONNECT') {
+  if (upgrade) {
     // On CONNECT or upgrade, block pipeline from dispatching further
     // requests on this connection.
 
diff --git a/test/proxy-agent.js b/test/proxy-agent.js
@@ -520,7 +520,7 @@ test('ProxyAgent correctly sends headers when using fetch - #1355, #1623', async
 
   const expectedProxyHeaders = {
     host: `localhost:${server.address().port}`,
-    connection: 'close'
+    connection: 'keep-alive'
   }
 
   proxy.on('connect', (req, res) => {

Original file line number	Diff line number	Diff line change
`@@ -1101,7 +1101,7 @@ function writeH1 (client, request) {`
`1101`	`1101`	`socket[kReset] = true`
`1102`	`1102`	`}`
`1103`	`1103`
`1104`		`- if (upgrade \|\| method === 'CONNECT') {`
	`1104`	`+ if (upgrade) {`
`1105`	`1105`	`// On CONNECT or upgrade, block pipeline from dispatching further`
`1106`	`1106`	`// requests on this connection.`
`1107`	`1107`
Original file line number	Diff line number	Diff line change
`@@ -520,7 +520,7 @@ test('ProxyAgent correctly sends headers when using fetch - #1355, #1623', async`
`520`	`520`
`521`	`521`	`const expectedProxyHeaders = {`
`522`	`522`	host: `localhost:${server.address().port}`,
`523`		`- connection: 'close'`
	`523`	`+ connection: 'keep-alive'`
`524`	`524`	`}`
`525`	`525`
`526`	`526`	`proxy.on('connect', (req, res) => {`