chore: noop per file (#3544)

Uzlopak · web-flow · commit 4b8958a228aa · 2024-09-04T18:13:30.000+02:00
diff --git a/lib/api/api-pipeline.js b/lib/api/api-pipeline.js
@@ -15,6 +15,8 @@ const {
 const util = require('../core/util')
 const { addSignal, removeSignal } = require('./abort-signal')
 
+function noop () {}
+
 const kResume = Symbol('resume')
 
 class PipelineRequest extends Readable {
@@ -92,7 +94,7 @@ class PipelineHandler extends AsyncResource {
     this.context = null
     this.onInfo = onInfo || null
 
-    this.req = new PipelineRequest().on('error', util.nop)
+    this.req = new PipelineRequest().on('error', noop)
 
     this.ret = new Duplex({
       readableObjectMode: opts.objectMode,
@@ -183,7 +185,7 @@ class PipelineHandler extends AsyncResource {
         context
       })
     } catch (err) {
-      this.res.on('error', util.nop)
+      this.res.on('error', noop)
       throw err
     }
 
diff --git a/lib/api/api-request.js b/lib/api/api-request.js
@@ -6,6 +6,8 @@ const { Readable } = require('./readable')
 const { InvalidArgumentError, RequestAbortedError } = require('../core/errors')
 const util = require('../core/util')
 
+function noop () {}
+
 class RequestHandler extends AsyncResource {
   constructor (opts, callback) {
     if (!opts || typeof opts !== 'object') {
@@ -38,7 +40,7 @@ class RequestHandler extends AsyncResource {
       super('UNDICI_REQUEST')
     } catch (err) {
       if (util.isStream(body)) {
-        util.destroy(body.on('error', util.nop), err)
+        util.destroy(body.on('error', noop), err)
       }
       throw err
     }
@@ -159,7 +161,7 @@ class RequestHandler extends AsyncResource {
       this.body = null
 
       if (util.isStream(body)) {
-        body.on('error', util.nop)
+        body.on('error', noop)
         util.destroy(body, err)
       }
     }
diff --git a/lib/api/api-stream.js b/lib/api/api-stream.js
@@ -7,6 +7,8 @@ const { InvalidArgumentError, InvalidReturnValueError } = require('../core/error
 const util = require('../core/util')
 const { addSignal, removeSignal } = require('./abort-signal')
 
+function noop () {}
+
 class StreamHandler extends AsyncResource {
   constructor (opts, factory, callback) {
     if (!opts || typeof opts !== 'object') {
@@ -39,7 +41,7 @@ class StreamHandler extends AsyncResource {
       super('UNDICI_STREAM')
     } catch (err) {
       if (util.isStream(body)) {
-        util.destroy(body.on('error', util.nop), err)
+        util.destroy(body.on('error', noop), err)
       }
       throw err
     }
diff --git a/lib/core/util.js b/lib/core/util.js
@@ -67,8 +67,6 @@ function wrapRequestBody (body) {
   }
 }
 
-function nop () {}
-
 function isStream (obj) {
   return obj && typeof obj === 'object' && typeof obj.pipe === 'function' && typeof obj.on === 'function'
 }
@@ -664,7 +662,6 @@ Object.setPrototypeOf(normalizedMethodRecords, null)
 
 module.exports = {
   kEnumerableProperty,
-  nop,
   isDisturbed,
   toUSVString,
   isUSVString,

Original file line number	Diff line number	Diff line change
`@@ -6,6 +6,8 @@ const { Readable } = require('./readable')`
`6`	`6`	`const { InvalidArgumentError, RequestAbortedError } = require('../core/errors')`
`7`	`7`	`const util = require('../core/util')`
`8`	`8`
	`9`	`+function noop () {}`
	`10`	`+`
`9`	`11`	`class RequestHandler extends AsyncResource {`
`10`	`12`	`constructor (opts, callback) {`
`11`	`13`	`if (!opts \|\| typeof opts !== 'object') {`
`@@ -38,7 +40,7 @@ class RequestHandler extends AsyncResource {`
`38`	`40`	`super('UNDICI_REQUEST')`
`39`	`41`	`} catch (err) {`
`40`	`42`	`if (util.isStream(body)) {`
`41`		`- util.destroy(body.on('error', util.nop), err)`
	`43`	`+ util.destroy(body.on('error', noop), err)`
`42`	`44`	`}`
`43`	`45`	`throw err`
`44`	`46`	`}`
`@@ -159,7 +161,7 @@ class RequestHandler extends AsyncResource {`
`159`	`161`	`this.body = null`
`160`	`162`
`161`	`163`	`if (util.isStream(body)) {`
`162`		`- body.on('error', util.nop)`
	`164`	`+ body.on('error', noop)`
`163`	`165`	`util.destroy(body, err)`
`164`	`166`	`}`
`165`	`167`	`}`
Original file line number	Diff line number	Diff line change
`@@ -67,8 +67,6 @@ function wrapRequestBody (body) {`
`67`	`67`	`}`
`68`	`68`	`}`
`69`	`69`
`70`		`-function nop () {}`
`71`		`-`
`72`	`70`	`function isStream (obj) {`
`73`	`71`	`return obj && typeof obj === 'object' && typeof obj.pipe === 'function' && typeof obj.on === 'function'`
`74`	`72`	`}`
`@@ -664,7 +662,6 @@ Object.setPrototypeOf(normalizedMethodRecords, null)`
`664`	`662`
`665`	`663`	`module.exports = {`
`666`	`664`	`kEnumerableProperty,`
`667`		`- nop,`
`668`	`665`	`isDisturbed,`
`669`	`666`	`toUSVString,`
`670`	`667`	`isUSVString,`