fix: fetch a long base64 url will crash and nothing happens (close: #1574) (#1575)

ahaoboy · web-flow · commit 40af2c052d92 · 2022-07-25T16:17:34.000+02:00
diff --git a/lib/fetch/dataURL.js b/lib/fetch/dataURL.js
@@ -255,7 +255,7 @@ function percentDecode (input) {
   }
 
   // 3. Return output.
-  return Uint8Array.of(...output)
+  return Uint8Array.from(output)
 }
 
 // https://mimesniff.spec.whatwg.org/#parse-a-mime-type
diff --git a/test/fetch/data-uri.js b/test/fetch/data-uri.js
@@ -104,7 +104,7 @@ test('https://url.spec.whatwg.org/#string-percent-decode', (t) => {
     const percentDecoded = stringPercentDecode(input)
     const expected = [...input].map(c => c.charCodeAt(0))
 
-    t.same(percentDecoded, Uint8Array.of(...expected))
+    t.same(percentDecoded, Uint8Array.from(expected))
     t.end()
   })
 
@@ -211,5 +211,21 @@ test('processing.any.js', async (t) => {
     }
   }
 
+  // https://github.com/nodejs/undici/issues/1574
+  test('too long base64 url', async (t) => {
+    const inputStr = 'a'.repeat(1 << 20)
+    const base64 = Buffer.from(inputStr).toString('base64')
+    const dataURIPrefix = 'data:application/octet-stream;base64,'
+    const dataURL = dataURIPrefix + base64
+    try {
+      const res = await fetch(dataURL)
+      const buf = await res.arrayBuffer()
+      const outputStr = Buffer.from(buf).toString('ascii')
+      t.same(outputStr, inputStr)
+    } catch (e) {
+      t.fail(`failed to fetch ${dataURL}`)
+    }
+  })
+
   t.end()
 })

Original file line number	Diff line number	Diff line change
`@@ -255,7 +255,7 @@ function percentDecode (input) {`
`255`	`255`	`}`
`256`	`256`
`257`	`257`	`// 3. Return output.`
`258`		`- return Uint8Array.of(...output)`
	`258`	`+ return Uint8Array.from(output)`
`259`	`259`	`}`
`260`	`260`
`261`	`261`	`// https://mimesniff.spec.whatwg.org/#parse-a-mime-type`