fix: omit 'path' in undici.request opts (ts) (#559)

apostolos · web-flow · commit 37aa2cc057d9 · 2021-02-23T17:19:12.000+01:00
diff --git a/test/types/agent.test-d.ts b/test/types/agent.test-d.ts
@@ -18,16 +18,16 @@ expectAssignable<Agent>(new Agent({}))
 
 {
   expectAssignable<PromiseLike<Client.ResponseData>>(request(''))
-  expectAssignable<PromiseLike<Client.StreamData>>(stream('', { path: '', method: '' }, data => {
+  expectAssignable<PromiseLike<Client.StreamData>>(stream('', { method: '' }, data => {
     expectAssignable<Client.StreamFactoryData>(data)
     return new Writable()
   }))
   expectAssignable<PromiseLike<Client.ResponseData>>(request(''))
 }
 
 {
-  expectAssignable<Duplex>(pipeline('', { path: '', method: '' }, data => {
+  expectAssignable<Duplex>(pipeline('', { method: '' }, data => {
     expectAssignable<Client.PipelineHandlerData>(data)
     return new Readable()
   }))
-}
+}
diff --git a/types/agent.d.ts b/types/agent.d.ts
@@ -21,17 +21,17 @@ declare function setGlobalAgent<AgentImplementation extends Agent>(agent: AgentI
 
 declare function request(
   url: string | URL | UrlObject,
-  opts?: { agent?: Agent } & Client.RequestOptions,
+  opts?: { agent?: Agent } & Omit<Client.RequestOptions, 'path'>,
 ): PromiseLike<Client.ResponseData>;
 
 declare function stream(
   url: string | URL | UrlObject,
-  opts: { agent?: Agent } & Client.RequestOptions,
+  opts: { agent?: Agent } & Omit<Client.RequestOptions, 'path'>,
   factory: Client.StreamFactory
 ): PromiseLike<Client.StreamData>;
 
 declare function pipeline(
   url: string | URL | UrlObject,
-  opts: { agent?: Agent } & Client.PipelineOptions,
+  opts: { agent?: Agent } & Omit<Client.PipelineOptions, 'path'>,
   handler: Client.PipelineHandler
-): Duplex;
+): Duplex;

Original file line number	Diff line number	Diff line change
`@@ -18,16 +18,16 @@ expectAssignable<Agent>(new Agent({}))`
`18`	`18`
`19`	`19`	`{`
`20`	`20`	`expectAssignable<PromiseLike<Client.ResponseData>>(request(''))`
`21`		`- expectAssignable<PromiseLike<Client.StreamData>>(stream('', { path: '', method: '' }, data => {`
	`21`	`+ expectAssignable<PromiseLike<Client.StreamData>>(stream('', { method: '' }, data => {`
`22`	`22`	`expectAssignable<Client.StreamFactoryData>(data)`
`23`	`23`	`return new Writable()`
`24`	`24`	`}))`
`25`	`25`	`expectAssignable<PromiseLike<Client.ResponseData>>(request(''))`
`26`	`26`	`}`
`27`	`27`
`28`	`28`	`{`
`29`		`- expectAssignable<Duplex>(pipeline('', { path: '', method: '' }, data => {`
	`29`	`+ expectAssignable<Duplex>(pipeline('', { method: '' }, data => {`
`30`	`30`	`expectAssignable<Client.PipelineHandlerData>(data)`
`31`	`31`	`return new Readable()`
`32`	`32`	`}))`
`33`		`-}`
	`33`	`+}`