add node v24 workflow (#4206)

tsctx · web-flow · commit 2ed2a8a1393b · 2025-05-13T00:29:13.000-07:00
* add node v24 workflow

* fix http2 test

* update wpt status
diff --git a/.github/workflows/nodejs-shared.yml b/.github/workflows/nodejs-shared.yml
@@ -19,7 +19,7 @@ jobs:
       fail-fast: false
       max-parallel: 0
       matrix:
-        version: [20, 22, 23]
+        version: [20, 22, 24]
     runs-on: ubuntu-latest
     timeout-minutes: 120
     steps:
diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml
@@ -58,7 +58,7 @@ jobs:
         node-version:
           - 20
           - 22
-          - 23
+          - 24
         runs-on:
           - ubuntu-latest
           - windows-latest
@@ -75,7 +75,7 @@ jobs:
       fail-fast: false
       max-parallel: 0
       matrix:
-        version: [20, 22, 23]
+        version: [20, 22, 24]
     runs-on: ubuntu-latest
     timeout-minutes: 120
     steps:
diff --git a/test/http2.js b/test/http2.js
@@ -1527,7 +1527,7 @@ test('#3046 - GOAWAY Frame', async t => {
   t.strictEqual(response.headers['x-custom-h2'], 'hello')
   t.strictEqual(response.statusCode, 200)
 
-  t.rejects(response.body.text(), {
+  await t.rejects(response.body.text(), {
     message: 'HTTP/2: "GOAWAY" frame received with code 0',
     code: 'UND_ERR_SOCKET'
   })
@@ -1748,9 +1748,11 @@ test('Should handle http2 stream timeout', async t => {
     body: stream
   })
 
-  t.rejects(res.body.text(), {
+  await t.rejects(res.body.text(), {
     message: 'HTTP/2: "stream timeout after 50"'
   })
+
+  await t.completed
 })
 
 test('Should handle http2 trailers', async t => {
diff --git a/test/wpt/status/fetch.status.json b/test/wpt/status/fetch.status.json
@@ -57,11 +57,14 @@
         "skip": true
       },
       "request-headers.any.js": {
+        "note": "Float16Array is valid from node v24.",
         "fail": [
           "Fetch with Chicken",
           "Fetch with Chicken with body",
           "Fetch with TacO and mode \"same-origin\" needs an Origin header",
-          "Fetch with TacO and mode \"cors\" needs an Origin header",
+          "Fetch with TacO and mode \"cors\" needs an Origin header"
+        ],
+        "flaky": [
           "Fetch with POST with Float16Array body"
         ]
       },
@@ -70,8 +73,8 @@
         "skip": true
       },
       "request-upload.any.js": {
-        "note": "no Float16Array",
-        "fail": [
+        "note": "Float16Array is valid from node v24.",
+        "flaky": [
           "Fetch with POST with Float16Array body"
         ]
       },
