fix: fire close on failed WebSocket connection (#3566)

eXhumer · web-flow · commit 290e0e1eb87d · 2024-09-20T06:15:54.000+02:00
* see #3546, #3548 & #3565 Signed-off-by: eXhumer <exhumer@exhumer.cc>
diff --git a/lib/web/websocket/websocket.js b/lib/web/websocket/websocket.js
@@ -537,6 +537,14 @@ class WebSocket extends EventTarget {
         message: reason
       })
     }
+
+    if (!this.#parser && !this.#handler.receivedClose) {
+      fireEvent('close', this, (type, init) => new CloseEvent(type, init), {
+        wasClean: false,
+        code: 1006,
+        reason
+      })
+    }
   }
 
   #onMessage (type, data) {
diff --git a/test/websocket/issue-3546.js b/test/websocket/issue-3546.js
@@ -5,7 +5,7 @@ const { WebSocket } = require('../..')
 const { tspl } = require('@matteo.collina/tspl')
 
 test('first error than close event is fired on failed connection', async (t) => {
-  const { completed, strictEqual } = tspl(t, { plan: 2 })
+  const { completed, strictEqual } = tspl(t, { plan: 4 })
   const ws = new WebSocket('ws://localhost:1')
 
   let orderOfEvents = 0

Original file line number	Diff line number	Diff line change
`@@ -537,6 +537,14 @@ class WebSocket extends EventTarget {`
`537`	`537`	`message: reason`
`538`	`538`	`})`
`539`	`539`	`}`
	`540`	`+`
	`541`	`+ if (!this.#parser && !this.#handler.receivedClose) {`
	`542`	`+ fireEvent('close', this, (type, init) => new CloseEvent(type, init), {`
	`543`	`+ wasClean: false,`
	`544`	`+ code: 1006,`
	`545`	`+ reason`
	`546`	`+ })`
	`547`	`+ }`
`540`	`548`	`}`
`541`	`549`
`542`	`550`	`#onMessage (type, data) {`