feat(h2): emit connectionError upon GOAWAY frame (#4123)

metcoder95 · web-flow · commit 1866f1f23336 · 2025-03-28T11:40:58.000+01:00
diff --git a/lib/dispatcher/client-h2.js b/lib/dispatcher/client-h2.js
@@ -208,6 +208,7 @@ function onHttp2SessionGoAway (errorCode) {
   assert(client[kRunning] === 0)
 
   client.emit('disconnect', client[kUrl], [client], err)
+  client.emit('connectionError', client[kUrl], [client], err)
 
   client[kResume]()
 }
diff --git a/test/http2.js b/test/http2.js
@@ -1492,7 +1492,7 @@ test('#3046 - GOAWAY Frame', async t => {
     allowH2: true
   })
 
-  t = tspl(t, { plan: 7 })
+  t = tspl(t, { plan: 10 })
   after(() => client.close())
   after(() => server.close())
 
@@ -1502,6 +1502,12 @@ test('#3046 - GOAWAY Frame', async t => {
     t.strictEqual(err.message, 'HTTP/2: "GOAWAY" frame received with code 0')
   })
 
+  client.on('connectionError', (url, disconnectClient, err) => {
+    t.ok(url instanceof URL)
+    t.deepStrictEqual(disconnectClient, [client])
+    t.strictEqual(err.message, 'HTTP/2: "GOAWAY" frame received with code 0')
+  })
+
   const response = await client.request({
     path: '/',
     method: 'GET',

Original file line number	Diff line number	Diff line change
`@@ -208,6 +208,7 @@ function onHttp2SessionGoAway (errorCode) {`
`208`	`208`	`assert(client[kRunning] === 0)`
`209`	`209`
`210`	`210`	`client.emit('disconnect', client[kUrl], [client], err)`
	`211`	`+ client.emit('connectionError', client[kUrl], [client], err)`
`211`	`212`
`212`	`213`	`client[kResume]()`
`213`	`214`	`}`