Skip to content

Add bail out#22

Merged
cclauss merged 4 commits intonodejs:masterfrom
fmartinsons:add-bail-out
May 9, 2021
Merged

Add bail out#22
cclauss merged 4 commits intonodejs:masterfrom
fmartinsons:add-bail-out

Conversation

@fmartinsons
Copy link
Contributor

@fmartinsons fmartinsons commented May 8, 2021

Hello,

this MR principally add the Bail Out! pattern support as defined in https://testanything.org/tap-version-13-specification.html.
I also add an option to make the xml output compact and improve XML generation for tests that have been not found (for example after a Bail Out).

I also added a test file to emphasize the change. For information this test file gives

<?xml version="1.0" encoding="utf-8"?>
<testsuites disabled="0" errors="0" failures="2" tests="5" time="0.0">
	<testsuite disabled="0" errors="0" failures="2" name="test-bailout" skipped="0" tests="5" time="0" hostname="SGX-CMP-776">
		<testcase name="/MyTest/1"/>
		<testcase name="/MyTest/2"/>
		<testcase name="/MyTest/3"/>
		<testcase name="None">
			<failure type="failure" message=" (0)"/>
		</testcase>
		<testcase name="None">
			<failure type="failure" message=" (0)"/>
		</testcase>
	</testsuite>
</testsuites>

for the master and

<?xml version="1.0" encoding="utf-8"?>
<testsuites disabled="0" errors="1" failures="1" tests="5" time="0.0">
	<testsuite disabled="0" errors="1" failures="1" name="test/fixtures/test-bailout" skipped="0" tests="5" time="0" hostname="SGX-CMP-776">
		<testcase name="/MyTest/1"/>
		<testcase name="/MyTest/2"/>
		<testcase name="/MyTest/3"/>
		<testcase name="Bail out for Test 4">
			<failure type="failure" message=" (0)"/>
			<system-err>Fatal condition met which prevent to continue</system-err>
		</testcase>
		<testcase name="Test 5 missing">
			<error type="-1" message="missing (-1)"/>
		</testcase>
	</testsuite>
</testsuites>

with this MR

@cclauss
Copy link
Collaborator

cclauss commented May 8, 2021

We will need to reestablish tests on GitHub Actions.

@fmartinsons
Copy link
Contributor Author

fmartinsons commented May 8, 2021

Ok, can I do something for that ?

cclauss
cclauss reviewed May 8, 2021
View reviewed changes
cclauss
cclauss reviewed May 8, 2021
View reviewed changes
cclauss
cclauss reviewed May 8, 2021
View reviewed changes
@cclauss
Copy link
Collaborator

cclauss commented May 8, 2021

Closing and reopening to rebase.

@cclauss cclauss closed this May 8, 2021
@cclauss cclauss reopened this May 8, 2021
@cclauss
Copy link
Collaborator

cclauss commented May 8, 2021

Please add the test to https://github.com/nodejs/tap2junit/blob/master/.github/workflows/lint_python.yml#L22

fmartinsons and others added 4 commits May 9, 2021 06:57
@fmartinsons
Add an option to disable pretty printing
3523604 
It can be useful to save some space on disk for big files.

Signed-off-by: Frederic Martinsons <[email protected]>
@fmartinsons
Add Bail Out parsing as TAP version 13 specifies it.
58803c7 
Signed-off-by: Frederic Martinsons <[email protected]>
@fmartinsons
Improve XML output for missing tests
b29784b 
And a test case for Bail Out

Signed-off-by: Frederic Martinsons <[email protected]>
@fmartinsons
Update lint_python to add test file on bailout
fbc0e11 
Add recursive option for isort and update .gitignore for mypy generated directory

Signed-off-by: Frederic Martinsons <[email protected]>
@cclauss cclauss merged commit be4ce46 into nodejs:master May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fmartinsons @cclauss