Conversation
LICENSE
Outdated
| same "printed page" as the copyright notice for easier | ||
| identification within third-party archives. | ||
|
|
||
| Copyright [yyyy] [name of copyright owner] |
There was a problem hiding this comment.
as far as I know it's only this bit, from here down, that needs to be included. I don't know what year it should be, or who the copyright owner should be, maybe that's @jbergstroem since it's his original code.
There was a problem hiding this comment.
From the URL in the commit message: Copyright 2019, Red Hat, Inc.
There was a problem hiding this comment.
I looked through several of the https://github.com/apache projects as well as several of the open source projects of my employer (https://github.com/IBM) and in all cases, if there was a Apache LICENSE file then that file contained the full text of the license.
There was a problem hiding this comment.
| same "printed page" as the copyright notice for easier | ||
| identification within third-party archives. | ||
|
|
||
| Copyright 2019 Red Hat, Inc. |
There was a problem hiding this comment.
sorry, this should go back to what it used to say, it doesn't make sense in this context. for reference, the original apache: https://github.com/apache/httpd/blob/trunk/LICENSE#L189
Just leaving the whole file in verbatim is fine, deleting the appendex, line 178 and on down, would be OK, but why look for more work, and Apache itself left it.
There was a problem hiding this comment.
This is what it looks like when the directions in the appendix are followed:
Lines 1 to 15 in dab991d
|
Hello there, This is an open PR for a long time and since I'm planned to use this tool in my project, I'll be more comfortable to have a clear LICENCE disclosure. Can I do something to make this land ? |
|
Let me know what I can do to help this move forward |
|
@cclauss ping |
Upstream has relicensed to Apache License, Version 2.0 so we add that LICENSE file.
Also see: nodejs/admin#413
@nodejs/python