Skip to content

Review Code Scanning Alerts #1453

Closed
Closed

Activity

  1. RafaelGSS commented on May 8, 2025

    @RafaelGSS
    MemberAuthor

    We should ignore CodeQL on deps/

  2. richardlau commented on May 8, 2025

    @richardlau
    Member

    We should probably exclude the same directories for CodeQL as we do for Coverity.

  3. RafaelGSS commented on Jun 5, 2025

    @RafaelGSS
    MemberAuthor

    Rules

    1. Unnecessary pins of packages maintained by Node.js. We trust packages that are maintained by the Node.js team.
    2. For Dockerfile that pull images from the official well-known operating system distributions, we don't require having those versions pinned by hash -- It's better to get security fixes asap, as delaying it by waiting for an automated update.

    Questions

    Can we pin this? https://github.com/nodejs/node/security/code-scanning/774 @F3n67u (tagging you as you were the one who wrote that file)

  4. RafaelGSS commented on Aug 18, 2025

    @RafaelGSS
    MemberAuthor

    I have cleaned it up. Ignoring all deps/*.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions