Conversation
To match eslint settings for JavaScript
aduh95
reviewed
Feb 26, 2024
Contributor
aduh95
left a comment
aduh95
left a comment
There was a problem hiding this comment.
Won't this require a massive PR on nodejs/node because format-md suddenly wants to change all the markdown files?
Member
Author
|
I don't ever recall when I write a line that could've been longer, format-md would attempt to make it longer than it already is. Locally modifying https://github.com/nodejs/node/blob/a8de25ed1523594dd6bf0ee08a24f146d38cb4e8/tools/lint-md/lint-md.mjs#L19519 and running |
Member
Author
|
cc @nodejs/linting |
aduh95
approved these changes
Mar 10, 2024
github-actions Bot
pushed a commit
that referenced
this pull request
Apr 18, 2024
## [5.0.1](v5.0.0...v5.0.1) (2024-04-18) ### Bug Fixes * update maximum line length to 120 ([#500](#500)) ([dca7621](dca7621)) ### Trivial Changes * add semantic-release automatic releases ([9dfa537](9dfa537)) * remove rule already included by recommended rules ([9e1d369](9e1d369)) * upgrade to ESLint 9 for dev tooling ([a213da9](a213da9))
|
🎉 This PR is included in version 5.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To match eslint settings for JavaScript