lint: update a name that wasn't capitalized#340
Merged
Trott merged 4 commits intonodejs:mainfrom Feb 15, 2022
Merged
Conversation
I've found some docs that don't capitalize the first letter of Valgrind (namely the contributor doc related to investigating native memory leaks). This additional lint should help to fix that grammatical issue.
nschonni
reviewed
Feb 15, 2022
Thanks, @nschonni! Co-authored-by: Nick Schonning <[email protected]>
nschonni
reviewed
Feb 15, 2022
Member
|
You'll need a corresponding PR in the other repo to clean it up, before the CI here will go green |
Contributor
Author
|
Already on it! |
Contributor
Author
|
Finished this a while ago but forgot to link the PR |
Trott
reviewed
Feb 15, 2022
index.js
Outdated
| { no: "[Rr][Ff][Cc]\\d+", yes: "RFC <number>" }, | ||
| { yes: "Unix" }, | ||
| { yes: "V8" }, | ||
| { no: "valgrind", yes: "Valgrind" }, |
Member
There was a problem hiding this comment.
Thanks for the PR. Two comments:
- We don't need the
noentry in this case. Just theyesis enough (and will prevent people from doing other things likeValGrindorVALGRIND). - The entries are in alphabetical order. Can you move this one up one line (so it's after
Unixand beforeV8)?
Contributor
Author
There was a problem hiding this comment.
Can do, and will do! :)
- Update index.js to remove unnecessary `no` clause - Move it to alphabetical order
richardlau
approved these changes
Feb 15, 2022
Trott
approved these changes
Feb 15, 2022
Member
|
Whoops, I should have squashed rather than rebased. Going to force push to fix that. |
Member
|
Thanks for the contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've found some docs that don't capitalize the first letter of Valgrind (namely the contributor doc related to investigating native memory leaks). This additional lint should help to fix that grammatical issue.