test: skip mustCall checks if there's already an error#281
Merged
aduh95 merged 1 commit intonodejs:mainfrom Oct 11, 2021
Merged
test: skip mustCall checks if there's already an error#281aduh95 merged 1 commit intonodejs:mainfrom
mustCall checks if there's already an error#281aduh95 merged 1 commit intonodejs:mainfrom
Conversation
This avoids double reporting of hte same error.
nschonni
reviewed
Oct 11, 2021
nschonni
approved these changes
Oct 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids double reporting of the same error.
The
The Promise never fulfilledis not useful, as the error is already reported just above.