Skip to content

Use and extend remark-preset-lint-recommended#21

Merged
Trott merged 3 commits intonodejs:masterfrom
nschonni:add-remark-preset-lint-recommended
Oct 12, 2019
Merged

Use and extend remark-preset-lint-recommended#21
Trott merged 3 commits intonodejs:masterfrom
nschonni:add-remark-preset-lint-recommended

Conversation

@nschonni
Copy link
Copy Markdown
Member

@nschonni nschonni commented Sep 7, 2019

No description provided.

@nschonni nschonni changed the title chore: remove rules overlapping preset Use and extend remark-preset-lint-recommended Sep 7, 2019
@nschonni
Copy link
Copy Markdown
Member Author

nschonni commented Sep 7, 2019

The other preset https://github.com/remarkjs/remark-lint/tree/master/packages/remark-preset-lint-markdown-style-guide is a more prescriptive, so I thought I'd try this first

nschonni
nschonni commented Sep 7, 2019
View reviewed changes
Comment thread index.js Outdated
@nschonni nschonni force-pushed the add-remark-preset-lint-recommended branch 2 times, most recently from c37bd37 to 4c9c6da Compare September 12, 2019 05:19
@nschonni
Copy link
Copy Markdown
Member Author

nschonni commented Sep 14, 2019

@Trott any opinions on this?

@Trott
Copy link
Copy Markdown
Member

Trott commented Sep 14, 2019

@Trott any opinions on this?

No strong opinion either way. On the one hand, I like the standardization and I like having fewer direct dependencies. On the other hand, it does mean that we have more indirect dependencies in node_modules and we're not using a lot of them. I'm also not sure that the disabling of rules isn't or won't be maintenance friction. Overall, I'm a +0 on this and would be inclined to land it, but I'd prefer to see what other folks think. @watiled @richardlau

@Trott
Copy link
Copy Markdown
Member

Trott commented Sep 14, 2019

@watiled @richardlau

Whoops. @watilde

nschonni
nschonni commented Sep 14, 2019
View reviewed changes
Copy link
Copy Markdown
Member Author

@nschonni nschonni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Submitted nodejs/node#29558 which would allow turning on the reference link rules

Comment thread index.js Outdated
Comment thread index.js Outdated
@richardlau
Copy link
Copy Markdown
Member

richardlau commented Sep 19, 2019

@Trott any opinions on this?

No strong opinion either way. On the one hand, I like the standardization and I like having fewer direct dependencies. On the other hand, it does mean that we have more indirect dependencies in node_modules and we're not using a lot of them. I'm also not sure that the disabling of rules isn't or won't be maintenance friction. Overall, I'm a +0 on this and would be inclined to land it, but I'd prefer to see what other folks think. @watiled @richardlau

I also have no strong opinions either way.

@nschonni nschonni force-pushed the add-remark-preset-lint-recommended branch 3 times, most recently from 6f03cb1 to b52a512 Compare October 1, 2019 05:43
@Trott
Copy link
Copy Markdown
Member

Trott commented Oct 1, 2019

I do like how this (now, at least) means a little less configuration and a little more convention.

@nschonni nschonni force-pushed the add-remark-preset-lint-recommended branch from b52a512 to f80b9fa Compare October 1, 2019 06:10
watilde
watilde approved these changes Oct 1, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@watilde watilde left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea that can leverage community's effort

@XhmikosR XhmikosR mentioned this pull request Oct 1, 2019
Merged
@nschonni nschonni mentioned this pull request Oct 2, 2019
Closed
4 tasks
@mmarchini mmarchini mentioned this pull request Oct 3, 2019
Closed
@nschonni nschonni mentioned this pull request Oct 11, 2019
Closed
4 tasks
@nschonni nschonni force-pushed the add-remark-preset-lint-recommended branch from f80b9fa to 785ce79 Compare October 11, 2019 05:19
@nschonni nschonni force-pushed the add-remark-preset-lint-recommended branch from 785ce79 to 6dddae3 Compare October 12, 2019 04:26
@Trott Trott merged commit f24b17e into nodejs:master Oct 12, 2019
@nschonni nschonni deleted the add-remark-preset-lint-recommended branch October 12, 2019 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

+1 more reviewer

@watilde watilde watilde approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nschonni @Trott @richardlau @watilde @BridgeAR