Normalize on RFC <number>#15
Merged
Trott merged 2 commits intonodejs:masterfrom Mar 18, 2019
Merged
Conversation
Enforce a space between `RFC` and the number.
2 tasks
Member
|
First commit seems 👍 to me. Second commit, I think I'd prefer to see us do something upstream about Trott/remark-lint-prohibited-strings#2 to make it a bit more user-friendly. |
Member
OK, I've resolved that, and will push out a new version of that plugin, then incorporate it into this preset, and then land these changes. |
Trott
added a commit
that referenced
this pull request
Mar 18, 2019
remark-lint-prohibited-strings provides better messages for regexp-y things, which will come in handy for #15
Member
|
Look at this beautiful output! doc/api/buffer.md
181:17-181:35 warning Use "RFC <number>" instead of "RFC4648" prohibited-strings remark-lint
184:31-184:38 warning Use "RFC <number>" instead of "RFC1345" prohibited-strings remark-lint
doc/api/dns.md
115:65-115:72 warning Use "RFC" instead of "rfc" prohibited-strings remark-lint
115:65-115:72 warning Use "RFC <number>" instead of "rfc5952" prohibited-strings remark-lint
558:34-558:41 warning Use "RFC" instead of "rfc" prohibited-strings remark-lint
558:34-558:41 warning Use "RFC <number>" instead of "rfc5952" prohibited-strings remark-lint
561:52-561:59 warning Use "RFC" instead of "rfc" prohibited-strings remark-lint
561:52-561:59 warning Use "RFC <number>" instead of "rfc5952" prohibited-strings remark-lint
650:65-650:72 warning Use "RFC" instead of "rfc" prohibited-strings remark-lint
650:65-650:72 warning Use "RFC <number>" instead of "rfc5952" prohibited-strings remark-lint
1011:34-1011:41 warning Use "RFC" instead of "rfc" prohibited-strings remark-lint
1011:34-1011:41 warning Use "RFC <number>" instead of "rfc5952" prohibited-strings remark-lint
1014:52-1014:59 warning Use "RFC" instead of "rfc" prohibited-strings remark-lint
1014:52-1014:59 warning Use "RFC <number>" instead of "rfc5952" prohibited-strings remark-lint
doc/api/http.md
2091:23-2092:15 warning Use "RFC <number>" instead of "RFC2616" prohibited-strings remark-lint
doc/api/http2.md
3226:1-3227:17 warning Use "RFC <number>" instead of "RFC7540" prohibited-strings remark-lint |
Marlyfleitas
added a commit
to Marlyfleitas/Node-remark-preset-lint
that referenced
this pull request
Aug 26, 2022
remark-lint-prohibited-strings provides better messages for regexp-y things, which will come in handy for nodejs/remark-preset-lint-node#15
patrickm68
added a commit
to patrickm68/Node-preset-lint
that referenced
this pull request
Sep 14, 2023
remark-lint-prohibited-strings provides better messages for regexp-y things, which will come in handy for nodejs/remark-preset-lint-node#15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: nodejs/node#26695 (comment)
The first commit prohibits
rfcandRfcto enforce uppercaseRFC.As of nodejs/node@3b6344c this gives:
The second commit enforces a space between
RFCand the number. This is possibly an abuse of prohibited-strings, but it does catch the cases where the space is omitted (the user message isn't that clear, especially if you are unfamiliar with regular expressions). As of nodejs/node@3b6344c: