tests: add GitHub Actions CI#418
Conversation
|
Hmm, theoretically the Checks should have run, though I could (?) be wrong about that. Double checking in a dummy repo. |
|
What's the motivation for replacing Travis? |
Co-Authored-By: Michaël Zasso <[email protected]>
|
Per my understanding from a Build WG member when I asked about GitHub CI, it was agreed to attempt using GitHub CI in a few repos in the org that already use TravisCI. If it works as a reasonable replacement, it could eventually become that but for now perhaps not the goal we'd be going for. |
|
Looking into how I can trigger this correctly. Will update as appropriate ❤️ |
|
Ah, it looks like they're running on my repo, it's just not being surfaced here! Excellent. There's a failure with |
|
Passed! Details
It's worth noting that this GitHub Actions CI build was triggered 6 minutes ago (from time of comment) and already completed on all operating systems on all versions, while TravisCI is waiting to be queued 😬 Details
Edit: Link to passed run |
|
Also, I noticed that the Travis run only tests Linux. I'd be happy to remove |
mcollina
left a comment
mcollina
left a comment
There was a problem hiding this comment.
Good work! Are tests passing already on Windows?
Co-Authored-By: XhmikosR <[email protected]>
Seems like it 👍 |
vweevers
left a comment
vweevers
left a comment
There was a problem hiding this comment.
LGTM. Regarding Sauce Labs, I can open a PR to create a separate workflow with an upgraded airtap (which now supports GH Actions).
The GitHub action is done: https://github.com/saucelabs/sauce-connect-action |
|
@christian-bromann Nice, thanks! Though we no longer need it here. |
6 participants
PR to attempt adding GitHub Actions CI as a parallel to/eventual (?) replacement for TravisCI.
Varied a bit from the setups I've done so far, so I don't fully expect this to work on the first run. That said, I'll be working to get it passing.
Few things to note:
CMD=testandCMD=test-browseris relatively straightforward and documented here, but omitted from this PR since the PR does not currently include Sauce Labs.